[Buildroot] [PATCH 2/2] package/mesa3d: x11 needs EGL, GLX or a vulkan driver

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Aug 5 19:54:50 UTC 2021


On Sun, 29 Dec 2019 14:14:53 +0100
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> As specified in meson.build, x11 platform needs EGL, GLX or a vulkan
> driver:
> 
> if with_platform_x11
>   if with_any_vk or with_egl or (with_glx == 'dri' and with_dri_platform == 'drm')
>     pre_args += '-DHAVE_X11_PLATFORM'
>   endif
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e044609e603ca68695d842d08809fdcb35bc8127
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>  package/mesa3d/Config.in | 1 +
>  1 file changed, 1 insertion(+)

It has been such a long time, and mesa3d has seen so many chnages
since, that I doubt this patch still makes sense in its current form.
Could you respin the patch if it still fixes an issue that exists
today? In fact, you never replied to the feedback I gave, see
https://patchwork.ozlabs.org/project/buildroot/patch/20191229131453.327907-2-fontaine.fabrice@gmail.com/.

So I'll mark the patch as Rejected for now, but don't hesitate to
respin if you think this patch is still needed, but taking into account
the questions I had raised.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list