[Buildroot] [PATCH v2] configs/digilent_genesys_zu_defconfig: add Digilent Genesys ZU board (ZynqMP SoC)

[Luca Ceresoli]

Hi Alvaro,

On 05/08/21 10:47, Alvaro Gamez Machado wrote:
> This adds support the Digilent Genesys ZU development board.
> 
> Signed-off-by: Alvaro Gamez Machado <alvaro.gamez at hazent.com>
> 
> ---
> v1 -> v2:
> 
> * Clarify boot process of zynqmp on README
> * Note upstream source of YYLOC patch for kernel
> * Minimize psu_init_gpl.c using uboot's tool
> * Explain on its file how to generate a FIT image containing an FPGA bitfile
> * Explain existance of uboot environment file and add example of how to define
>   a generic UIO device
> 
> Signed-off-by: Alvaro Gamez Machado <alvaro.gamez at hazent.com>
> ---
>  ...ve-redundant-YYLOC-global-declaratio.patch |    54 +
>  .../0001-uboot-add-genesys-zu.patch           |    10 +
>  board/digilent/genesys-zu/GenesysZU.dts       |  1655 +
>  board/digilent/genesys-zu/README.txt          |   110 +
>  board/digilent/genesys-zu/genimage.cfg        |    28 +
>  board/digilent/genesys-zu/image.its           |    59 +
>  board/digilent/genesys-zu/kernel_defconfig    |   414 +
>  board/digilent/genesys-zu/pm_cfg_obj.c        |   630 +
>  board/digilent/genesys-zu/post-image.sh       |    10 +
>  board/digilent/genesys-zu/psu_init_gpl.c      |   985 +
>  board/digilent/genesys-zu/psu_init_gpl.h      | 37545 ++++++++++++++++

Sorry I forgot to mention it while reviewing v1, but psu_init_gpl.h is
not required at all, so just drop it.

> diff --git a/board/digilent/genesys-zu/GenesysZU.dts b/board/digilent/genesys-zu/GenesysZU.dts
> new file mode 100644
> index 0000000000..ddeba4b715
> --- /dev/null
> +++ b/board/digilent/genesys-zu/GenesysZU.dts

As you mentioned in the v1 discussion, a large part of this dts file is
just copied from zynqmp.dtsi in the kernel sources. You should really
replace all of that code with #include "zynqmp.dtsi" and have only the
board-specific code here.

> diff --git a/board/digilent/genesys-zu/genimage.cfg b/board/digilent/genesys-zu/genimage.cfg
> new file mode 100644
> index 0000000000..eeecfee37d
> --- /dev/null
> +++ b/board/digilent/genesys-zu/genimage.cfg
> @@ -0,0 +1,28 @@
> +image boot.vfat {
> +	vfat {
> +		files = {
> +			"boot.bin",
> +			"u-boot.itb",
> +			"GenesysZU.dtb",

Why is the dtb file both in FAT and in image.ub?

-- 
Luca