[Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate

[Arnout Vandecappelle]

On 27/08/2021 23:14, Conrad Ratschan via buildroot wrote:
> When BR2_REPRODUCIBLE is set and host-coreutils needs to be built, the
> fakedate script installed to `host/bin/date` will be overwritten by
> host-coreutils. Disable installing the `date` binary in host-coreutils
> when BR2_REPRODUCIBLE is set.
> 
> Signed-off-by: Conrad Ratschan <conrad.ratschan at collins.com>
> ---
>  package/coreutils/coreutils.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk
> index 65234a113e..1bdfe2f9cf 100644
> --- a/package/coreutils/coreutils.mk
> +++ b/package/coreutils/coreutils.mk
> @@ -164,5 +164,10 @@ HOST_COREUTILS_CONF_OPTS = \
>  	--without-gmp \
>  	--enable-install-program=ln,realpath

 We were supposed already to only install ln and realpath, so this issue
shouldn't have happened to begin with. Could you investigate in a bit more
detail why this --enable-install-program doesn't seem to do the trick?

>  
> +# Avoid overwriting fakedate when creating a reproducible build
> +ifeq ($(BR2_REPRODUCIBLE),y)

 If there really is no way to get enable-install-program to work correctly, then
we should probably not make this conditional on BR2_REPRODUCIBLE anyway.

 Regards,
 Arnout

> +HOST_COREUTILS_CONF_OPTS += --enable-no-install-program=date
> +endif
> +
>  $(eval $(autotools-package))
>  $(eval $(host-autotools-package))
>