[Buildroot] [PATCH v3 0/3] package/makedevs: allow recursive on directory with symlinks

Joachim Wiberg troglobit at gmail.com
Thu Dec 23 09:07:57 UTC 2021


Hi,

take three on fixing the problem with, as it turns out, *dangling*,
symlinks when running makedevs recursively on a directory.  Thanks to
Arnout for pointing this out!

As started in v2, this patch set includes a coding style cleanup, and
now also with a first .clang-format for Buildroot, as suggested by
Arnout.  I've not enforced it strictly on the code base, e.g. max line
lengths caused a way too big diff.

Best regards
 /Joachim

---

v3:
- Problem only applies to *dangling* symlinks, feedback from Arnout
  Patch updated to skip chmod() on symlinks that cannot be accessed
- Import .clang-format file from Linux 5.15.6, suggestion by Arnout
- Employ clang-format to improve coding style cleanup, see commit
  notes for exceptions made

v2: 
 - Use lchown() instead on symlinks, feedback from Yann
 - Initial coding style cleanup

v1:
 - Skip recursive chown() and chmod() on all symlinks

Joachim Wiberg (3):
  package/makedevs: allow recursive on directory with dangling symlinks
  .clang-format: initial import from Linux 5.15.6
  package/makedevs: coding style and whitespace cleanup

 .clang-format               | 566 ++++++++++++++++++++++++++++++++++++
 package/makedevs/makedevs.c | 119 ++++----
 2 files changed, 631 insertions(+), 54 deletions(-)
 create mode 100644 .clang-format



More information about the buildroot mailing list