[Buildroot] [PATCH 1/1] package/iwd: enable required kernel dependencies

[James Hilliard]

On Sat, Dec 4, 2021 at 1:28 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> On Wed, 1 Dec 2021 16:15:24 -0700
> James Hilliard <james.hilliard1 at gmail.com> wrote:
>
> > > > +define IWD_LINUX_CONFIG_FIXUPS
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_ASYMMETRIC_KEY_TYPE)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_AES)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_AES_NI_INTEL)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_AES_X86_64)
> > >
> > > Not sure if it is good idea to add the x86_64 specific ones unconditionally
> > > (they are marked in check_crypto() with ADD_OPTIONAL instead of ADD_MISSING)?
> >
> > Doesn't the infrastructure drop them automatically if they aren't selectable?
>
> I think the point that Peter Seiderer was trying to make is that
> CONFIG_CRYPTO_AES_NI_INTEL and CONFIG_CRYPTO_AES_X86_64 are not
> mandatory for iwd, and therefore shouldn't be forced enabled here.
>
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_CBC)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_CMAC)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_DES)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_DES3_EDE_X86_64)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_ECB)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_HMAC)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_MD4)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_MD5)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA1)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA1_SSSE3)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA256)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA256)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA256_SSSE3)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA512)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_SHA512_SSSE3)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_USER_API_HASH)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_USER_API_SKCIPHER)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_KEYS)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_KEY_DH_OPERATIONS)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_PKCS7_MESSAGE_PARSER)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_PKCS8_PRIVATE_KEY_PARSER)
> > > > +     $(call KCONFIG_ENABLE_OPT,CONFIG_X509_CERTIFICATE_PARSER)
> > > > +endef
>
> Does it strictly need *all* those options ? We don't want to be too
> aggressive in forcing kernel options. We should only force enable the
> ones that are absolutely mandatory for iwd to work. We should not force
> enable the options that *may* be used by iwd but are not needed in all
> cases.


Ok, wasn't sure since I thought they were always recommended to be enabled
if available for the arch specific optional opts, I removed the
optional opts in my v2:
https://patchwork.ozlabs.org/project/buildroot/patch/20211204234005.2051254-1-james.hilliard1@gmail.com/

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com