[Buildroot] [PATCH 1/3] package/opensc: new package

[José Pekkarinen]

On Fri, Dec 10, 2021 at 12:29 PM Giulio Benetti <
giulio.benetti at benettiengineering.com> wrote:

> Hi José,
>
> please use plain-text,
>

Sorry, google thingy, not sure I can fix it :\



> On 10/12/21 07:20, José Pekkarinen wrote:
> >
> >     Hi,
> >
> >     Any comments in the following patchset?
> >
> >     Thanks!
> >
> >     José
> >
> >
> > On Fri, Dec 3, 2021 at 10:37 AM José Pekkarinen
>
> Only 1 week has passed, backlog is pretty big(478 patches at the moment)
>

Sorry, I was following linux kernel guidances

of the rule of 1w, I'll be more patient next time.


> > <jose.pekkarinen at unikie.com <mailto:jose.pekkarinen at unikie.com>> wrote:
> >
> >     The patch will add a basic opensc package to build
> >     on buildroot.
>
> This commit log is not sufficient. Can you please take a look at other
> commit log on while adding a "new package"? Try to imitate, that's a
> good starting point.
>

Most I see have empty comment. Mind to elaborate

what is missing?

>     Signed-off-by: José Pekkarinen <jose.pekkarinen at unikie.com
> >     <mailto:jose.pekkarinen at unikie.com>>
>
> This ^^^ SoB has a strange format, how did you produce the patch?
> Also how did you set the user.email in git?
>

It is properly set, so either git send-email or google added

that extra feaure.


Thanks!

José.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20211210/c6140cbd/attachment-0001.html>