[Buildroot] [PATCH 09/10 v3] support/dependencies: drop check for maximal tar version

[Arnout Vandecappelle]

On 29/12/2020 12:01, Yann E. MORIN wrote:
> So far, we checked that the tar present on the host was at most tar
> 1.29, because tar 1.30 changed the way it generates archives.
> 
> Having a maximum tar version requirement meant that we would eventually
> always have to build our own host-tar, as distributions are updating
> the version they use.
> 
> But now, we have found a way to generate reproducible archives starting
> with tar 1.27 onward, so we no longer need the check for a maximum tar
> version, so we can drop that requirement.

 You could have simply reverted b8fa273d500b44153e9939f0a100e97db2ff63ed, but OK.

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

 Regards,
 Arnout

> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Vincent Fazio <vfazio at xes-inc.com>
> ---
>  support/dependencies/check-host-tar.sh | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/support/dependencies/check-host-tar.sh b/support/dependencies/check-host-tar.sh
> index 934cb61299..b7d607a47a 100755
> --- a/support/dependencies/check-host-tar.sh
> +++ b/support/dependencies/check-host-tar.sh
> @@ -33,14 +33,7 @@ fi
>  major_min=1
>  minor_min=27
>  
> -# Maximal version = 1.29 (1.30 changed --numeric-owner output for
> -# filenames > 100 characters). This is really a fix for a bug in
> -# earlier tar versions regarding deterministic output so it is
> -# unlikely to be reverted in later versions.
> -major_max=1
> -minor_max=29
> -
> -if [ $major -lt $major_min -o $major -gt $major_max ]; then
> +if [ $major -lt $major_min ]; then
>  	# echo nothing: no suitable tar found
>  	exit 1
>  fi
> @@ -50,10 +43,5 @@ if [ $major -eq $major_min -a $minor -lt $minor_min ]; then
>  	exit 1
>  fi
>  
> -if [ $major -eq $major_max -a $minor -gt $minor_max ]; then
> -	# echo nothing: no suitable tar found
> -	exit 1
> -fi
> -
>  # valid
>  echo $tar
>