[Buildroot] [PATCH 04/15] package/pkg-generic.mk: Fix .la files overwrite detection

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Jun 21 20:54:11 UTC 2021


On Mon, 21 Jun 2021 16:11:19 +0200
Herve Codina <herve.codina at bootlin.com> wrote:

> During per-package build, original .la files are modified by
> fixup-libtool-files calls.
> But since fixup-libtool-files modifies files using sed --in-place,
> these modification are done using a temporary file and a call to
> rename. Rename breaks the hardlink to the original file and leave the
> temporary file in per-package TARGET dir.
> As the original file is not modified, this is no longer considered as
> an overwrite.
> 
> To fix this detection, this patch simply considers the what is done

"the what" -> "that what"

> by fixup-libtool-files is part of the original snapshot used to
> detect overwrites. And so, the original snapshot is taken after
> fixup-libtool-files call.
> 
> Signed-off-by: Herve Codina <herve.codina at bootlin.com>

With that:

Reviewed-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list