[Buildroot] [PATCH] package/softhsm2: new package

[Arnout Vandecappelle]

On 17/10/2021 13:13, Gilles Talis wrote:
> Hi José,
> 
> Le ven. 15 oct. 2021 à 10:39, José Pekkarinen <jose.pekkarinen at unikie.com>
> a écrit :
> 

[snip]
>> +       depends on BR2_PACKAGE_LIBOPENSSL
>>
> Even though the package has openssl as a dependency, "select
> BR2_PACKAGE_LIBOPENSSL" is more appropriate here. It means that openssl
> will be automatically selected when softhsm2 is selected. "depends on"
> means that your package will not appear in the list if openssl is not
> already slected.

  You can't select libopenssl though.

  Instead, either:

- it works with libressl as well, and you select BR2_PACKAGE_OPENSSL; or
- it doesn't work with libressl, and you do:

         select BR2_PACKAGE_OPENSSL
         select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL


> By the way, it seems like botan is a potential crypto library dependency.
> If you want to give the user the choice between the crypto libraries to
> use, please have a look at package/libcurl/Config.in in the "choice"
> section.

  We usually try to do it automatically, like:

	select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_BOTAN

(and then conditionally use openssl or botan in the .mk file).


>> +       select BR2_PACKAGE_LIBTOOL
>>
> libtool does not need to be selected. buildroot build system will take care
> of installing it for you.

  host-libtool doesn't need to be selected. Target libtool, however, is never 
added automatically. That said, it's unlikely you actually need it on the target 
- basically if it links with libltdl.



  Regards,
  Arnout

[snip]