[Buildroot] [PATCH 1/2] support/scripts/pkg-stats: fix the status for packages found by guess

Arnout Vandecappelle arnout at mind.be
Thu Oct 21 19:09:12 UTC 2021



On 08/10/2021 23:21, Thomas Petazzoni wrote:
> The pkg-stats scripts tries to match packages against
> release-monitoring.org in two days:
> 
> - First by using the "Buildroot" distribution registered on
>    release-monitoring.org, in which we have added a lot of mappings
>    between Buildroot package names and release-monitoring.org package
>    names. If there is a match using this distribution, the package
>    status is RM_API_STATUS_FOUND_BY_DISTRO, which means that the
>    resulting HTML has a "found by distro" statement.
> 
> - Then, if the first solution didn't work, by using the pattern
>    matching, as done in the check_package_get_latest_version_by_guess()
>    function.
> 
> However, there is a bug in this later case: it sets the package status
> to RM_API_STATUS_FOUND_BY_DISTRO as well, while it should have been
> RM_API_STATUS_FOUND_BY_PATTERN. Due to this bug, in the resulting HTML
> file from a pkg-stats run, all packages are marked as "found by
> distro" even the ones that are "found by guess".
> 
> This commit fixes that by setting the correct package status.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
> This should be backported to stable branches of Buildroot.
> ---
>   support/scripts/pkg-stats | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats
> index cc91d13167..0f1521873f 100755
> --- a/support/scripts/pkg-stats
> +++ b/support/scripts/pkg-stats
> @@ -512,7 +512,7 @@ async def check_package_get_latest_version_by_guess(session, pkg, retry=True):
>   
>               if len(projects) > 0:
>                   check_package_latest_version_set_status(pkg,
> -                                                        RM_API_STATUS_FOUND_BY_DISTRO,
> +                                                        RM_API_STATUS_FOUND_BY_PATTERN,
>                                                           projects[0]['version'],
>                                                           projects[0]['id'])
>                   return True
> 



More information about the buildroot mailing list