[Buildroot] [PATCH 2/4] configs/stm32mp157*_dk*: dk2 is a superset of dk1

[Thomas Petazzoni]

On Sat, 23 Oct 2021 09:11:59 +0200
Francois Perrad <fperrad at gmail.com> wrote:

> the daughter board (DK2) contains a 4" LCD with backlight and touchscreen.

The DK2 is not a daughter board. The DK1 and DK2 are two separate
boards. Even though they share a lot of common aspects, the DK2 is not
a daughter board.

For example, the DK2 has a WiFi/Bluetooth chip, which the DK1 doesn't
have, and this is not on a daughter board (and actually also not
properly handled by your fragment, which only cares about the display
and not WiFi/BT).

Overall, I am not sure if this commit is a real improvement. I agree
that the two Linux kernel configuration files have a lot in common, but
switching to using a fragment makes it much harder to update the kernel
configuration file.

So I'm not fully against it, but I'm not sure this commit really
improves anything.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com