[Buildroot] [PATCH v5 4/4] package/python-scipy: new package
Arnout Vandecappelle
arnout at mind.be
Mon Aug 1 18:15:13 UTC 2022
On 01/08/2022 19:58, Guillaume Bres wrote:
> Hello,
> thank you Thomas for merging this serie and also for adding the runtime test, I
> did try to provide it but could not get it to work.
> I will give it a try in the next few days
Don't hesitate to post even a non-working version that people can comment on.
Please do post it as an RFC though (--subject-prefix=RFC). And of course there's
no promise that people will *actually* comment on it :-).
Regards,
Arnout
>
> Guillaume W. Bres
> Software engineer
> <guillaume.bressaix at gmail.com <mailto:guillaume.bressaix at gmail.com>>
>
>
> Le lun. 1 août 2022 à 19:42, Thomas Petazzoni <thomas.petazzoni at bootlin.com
> <mailto:thomas.petazzoni at bootlin.com>> a écrit :
>
> Hello,
>
> On Wed, 27 Jul 2022 21:29:48 +0200
> "Guillaume W. Bres" <guillaume.bressaix at gmail.com
> <mailto:guillaume.bressaix at gmail.com>> wrote:
>
> > From: Jagan Teki <jagan at amarulasolutions.com
> <mailto:jagan at amarulasolutions.com>>
> >
> > Signed-off-by: Jagan Teki <jagan at amarulasolutions.com
> <mailto:jagan at amarulasolutions.com>>
> > [Arnout:
> > - Indent hash file with two spaces.
> > - Bump to 1.7.3 to fix build failure with recent GCC.
> > - Get from github instead of PyPI.
> > - Add host-meson and host-python-pythran dependencies.
> > - Properly propagate Config.in dependencies.
> > - Correct usage of BR2_INSTALL_LIBSTDCPP symbol.
> > - Remove F77, no longer used.
> > ]
> > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be
> <mailto:arnout at mind.be>>
> > [Guillaume:
> > - -lnpymath: npymath.ini localization problem
> > - -lnpyrandom resolution problem
> > - fix legal-info for latest version LICENSE.txt
> > - zlib is a scipy::io module runtime requirement
> > - update serie for scipy 1.8.1 (latest)
> > ]
> > Signed-off-by: Guillaume W. Bres <guillaume.bressaix at gmail.com
> <mailto:guillaume.bressaix at gmail.com>>
>
> I have applied, with the following changes:
>
> [Thomas:
> - add runtime test
> - drop dependency on OpenBLAS, which is not needed in a minimal
> configuration
> - remove PYTHON_SCIPY_NPY_PKG_CONFIG_PATH logic as it is no longer
> needed
> ]
>
> Could you please:
>
> (1) Review the runtime test, to see if it can be improved with some
> better testing.
>
> (2) Review the OpenBLAS dependency, to see if it needs to be added as
> an optional dependency in some way.
>
> > +# Provide system configuration options to numpy distutils extenions, telling
> > +# to find all include files and libraries in staging directory.
> > +define PYTHON_SCIPY_CONFIGURE_CMDS
> > + -rm -f $(@D)/site.cfg
> > + echo "[DEFAULT]" >> $(@D)/site.cfg
> > + echo "library_dirs = $(STAGING_DIR)/usr/lib" >> $(@D)/site.cfg
> > + echo "include_dirs = $(STAGING_DIR)/usr/include" >> $(@D)/site.cfg
> > +endef
>
> This part is a bit annoying, as it's duplicated from python-numpy.mk
> <http://python-numpy.mk>. I
> looked a bit, but couldn't really find a good way of avoiding this
> duplication.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com <https://bootlin.com>
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
More information about the buildroot
mailing list