[Buildroot] [PATCH 1/1] package/netsniff-ng: needs NPTL

[Yann E. MORIN]

Fabrice, All,

On 2022-08-15 14:59 +0200, Fabrice Fontaine spake thusly:
> netsniff-ng unconditionally uses pthread_spin_lock since its addition in
> commit 500d287b07190c9c1a1284bc91b37d07e1a835a3 and
> https://github.com/netsniff-ng/netsniff-ng/commit/1a9fbac03c684f29cff9ac44875bd9504a89f54e
> resulting in the following build failure:
> 
> /home/autobuild/autobuild/instance-1/output-1/per-package/netsniff-ng/host/bin/../lib/gcc/x86_64-buildroot-linux-uclibc/10.3.0/../../../../x86_64-buildroot-linux-uclibc/bin/ld: netsniff-ng/tprintf.o: in function `tprintf_flush':
> tprintf.c:(.text+0x42c): undefined reference to `pthread_spin_lock'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/ceadbdea8cc35bfd7d601a6d4b18137f81f61406
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/netsniff-ng/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/netsniff-ng/Config.in b/package/netsniff-ng/Config.in
> index bbb4172cd3..9ad3628f14 100644
> --- a/package/netsniff-ng/Config.in
> +++ b/package/netsniff-ng/Config.in
> @@ -1,7 +1,7 @@
>  config BR2_PACKAGE_NETSNIFF_NG
>  	bool "netsniff-ng"
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_spin_lock
>  	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
>  	select BR2_PACKAGE_LIBPCAP
>  	select BR2_PACKAGE_LIBNETFILTER_CONNTRACK
> @@ -28,7 +28,7 @@ comment "mausezahn needs glibc or musl toolchain"
>  
>  endif
>  
> -comment "netsniff-ng needs a toolchain w/ threads, headers >= 3.0"
> +comment "netsniff-ng needs a toolchain w/ NPTL, headers >= 3.0"
>  	depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
>  		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'