[Buildroot] [PATCH 1/1] utils/genrandconfig: add jquery-ui-themes handling

Arnout Vandecappelle arnout at mind.be
Tue Aug 23 20:14:13 UTC 2022



On 23/08/2022 11:30, Yann E. MORIN wrote:
> Fabrice, All,
> 
> On 2022-08-21 14:03 +0200, Yann E. MORIN spake thusly:
>> On 2022-08-21 11:49 +0200, Yann E. MORIN spake thusly:
>>> On 2022-08-20 13:33 +0200, Fabrice Fontaine spake thusly:
>>>> Add a custom case to make sure that a random configuration with an empty
>>>> theme for jquery-ui-themes doesn't fail. It reverts to
>>>> BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE in that case.
>> [--SNIP--]
>>> I am not sure how we can end up with an empty BR2_PACKAGE_JQUERY_UI_THEMES_THEME.
>>> Indeed, it is filled from a choice, and unless there is a typo in one of
>>> the config options, there are as many defaults for it as there are
>>> entries in the choice...
>>>
>>> And if you look at the .config file, there is actually something
>>> selected in that choice, BR2_PACKAGE_JQUERY_UI_THEMES_VADER=y, but
>>> indeed BR2_PACKAGE_JQUERY_UI_THEMES_THEME is not even set. It's not that
>>> it is empty, it is not set at all!
>>>
>>> So, the .config file is not correct.
> [--SNIP--]
>> So, for fun, I had the following snippet run:
>>      while true; do
>>          ./utils/genrandconfig 2>&1 |grep KCONFIG_SEED=
>>          if grep -q BR2_PACKAGE_JQUERY_UI_THEMES=y .config; then
>>              echo 'Got JQuery UI themes...'
>>              grep BR2_PACKAGE_JQUERY_UI_THEMES_ .config
>>              grep -q BR2_PACKAGE_JQUERY_UI_THEMES_THEME= .config \
>>              || { echo 'Missing theme...'; break; }
>>          fi
>>      done
> 
> This has now been running for almost 48 hours straight, and there has
> been 10005 configs generated, 55 with BR2_PACKAGE_JQUERY_UI_THEMES
> enabled, of which none with BR2_PACKAGE_JQUERY_UI_THEMES_THEME unset.

  Isn't it simply fixed by commit f008c74061e604069d9716ac97d2a3f78c9f00b3 ? The 
autobuild failure didn't contain that commit yet.

  Patch marked as superseded.

  Regards,
  Arnout

> 
> Regards,
> Yann E. MORIN.
> 



More information about the buildroot mailing list