[Buildroot] [PATCH v6 4/8] package/qt5/qt5base: enable ccache via configure option

[Thomas Petazzoni]

On Sat,  5 Feb 2022 13:18:33 -0700
James Hilliard <james.hilliard1 at gmail.com> wrote:

>  # This allows to use ccache when available
> -define QT5BASE_CONFIGURE_HOSTCC
> -	$(SED) 's,^QMAKE_CC\s*=.*,QMAKE_CC = $(HOSTCC),' $(@D)/mkspecs/common/g++-base.conf
> -	$(SED) 's,^QMAKE_CXX\s*=.*,QMAKE_CXX = $(HOSTCXX),' $(@D)/mkspecs/common/g++-base.conf
> -endef

This this variable is dropped, then surely the place it was used should also be modified?

> +ifeq ($(BR2_CCACHE),y)
> +QT5BASE_CONFIGURE_OPTS += -ccache
> +endif

Are we sure this is going to use Buildroot's ccache and not the system
ccache?

Indeed, $(HOSTCC) and $(HOSTCXX) are defined as:

CCACHE = $(HOST_DIR)/bin/ccache
HOSTCC = $(CCACHE) $(HOSTCC_NOCCACHE)
HOSTCXX = $(CCACHE) $(HOSTCXX_NOCCACHE)

so we know that it's the Buildroot ccache that will be used.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com