[Buildroot] [PATCH v4 1/3] board/andes: rearrange andes folder structure

[Giulio Benetti]

Hi Peter,

On 23/02/22 11:09, Yu Chien Peter Lin wrote:
> Hi Giulio,
> 
>> On Wed, Feb 23, 2022 at 10:19:08AM +0100, Giulio Benetti wrote:
>>> Hi Peter,
>>>
>>> On 23/02/22 08:10, Yu Chien Peter Lin wrote:
>>>> Rename ae3xx to ae300 for nds32 architecture and add ae350 platform.
>>>>
>>>> AE300 (NDS32):
>>>> - http://www.andestech.com/en/products-solutions/andeshape-platforms/ae300/
>>>> AE350 (RISC-V):
>>>> - http://www.andestech.com/en/products-solutions/andeshape-platforms/ae350-axi-based-platform-pre-integrated-with-n25f-nx25f-a25-ax25/
>>>>
>>>> Signed-off-by: Yu Chien Peter Lin <peterlin at andestech.com>
>>>> Signed-off-by: Alan Kao <alankao at andestech.com>
>>>> ---
>>>> Changes v1 -> v2:
>>>>      - move linux source code and its patches to AndesTech Github repo
>>>>      - rename ae350_andestar45_defconfig to andes_ae350_45_defconfig
>>>>      - change C library to uClibc
>>>>      - remove OpenSSL package
>>>>      - remove rootfs.cpio and rootfs.tar
>>>>      - update DEVELOPERS
>>>> Changes v2 -> v3:
>>>>      - specifiy branch to download from AndesTech linux repo
>>>>      - change boot.cmd to extlinux.conf
>>>>      - add post-build.sh for extlinux.conf to retrieve Image and DTB
>>>>      - fix format and update genimage_sdcard.cfg
>>>>      - update readme.txt
>>>>      - add packages (python3, pylibfdt and openssl) for u-boot binman
>>>>      - reorder item in DEVELOPERS
>>>> Changes v3 -> v4:
>>>>      - rename ae3xx folder to ae300
>>>>      - rename andes_ae3xx_defconfig to andes_ae300_defconfig
>>>>      - update readme.txt and item in DEVELOPERS
>>>
>>> Some of these change ^^^ must have been moved to the single patch, like
>>> DEVELOPERS is updated in patch 3/3. I've also forgotten to point you to add
>>> a --cover-letter, so keep in mind both points for next time.
>>>
>>> I've built tested both defconfig successfully, so:
>>> Reviewed-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>>> Tested-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>>> [Giulio: build tested only]
>>>
>>> And the other patches of this series is all reviewed, so to me it's ready to
>>> be committed, but this will happen after Buildroot 2022.02 is released,
>>> since between rc1 to the release Maintainers only accept fixes. Another
>>> possibility is that they will commit these patches to next branch.
>>>
>>> Please remember to tag V3.
>>>
>>> Thank you for your effort!
>>>
>>> Best regards
>>> -- 
>>> Giulio Benetti
>>> Benetti Engineering sas
> 
> Thanks for reviewing my patches and the guidance.

You're welcome.

> I will make a new patch for the Config.in,

Which one? I only see:
toolchain/toolchain-external/toolchain-external-andes-nds32/Config.in

Do you mean you will add an entry in DEVELOPERS for it?

> The last question, is it tag V5 for the next submission?

It depends if you need to modify these patches. Or if you add a new 
patch that depends on these patches, then yes, please send a V5 with all 
changes moved to the different patches, including adding the patch if 
this is your goal.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas