[Buildroot] [git commit branch/2021.02.x] package/sofia-sip: correct passing of '--enable-ndebug'

Peter Korsgaard peter at korsgaard.com
Thu Jan 27 07:10:01 UTC 2022


commit: https://git.buildroot.net/buildroot/commit/?id=e9651f61bbc2d92598f852eba8d00753fa7ed010
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/2021.02.x

The preprocessor option NDEBUG, triggered by the configure option
'--enable-ndebug', should be read as 'no-debug'. When NDEBUG is set, asserts
are _disabled_.

The sofia-sip package had inverted logic, and set '--enable-ndebug' when
BR2_ENABLE_DEBUG was enabled, while it should be the other way around.

Reported-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
(cherry picked from commit fb12adbb7613a4c05643491453dbc09151b5bf48)
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
 package/sofia-sip/sofia-sip.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/sofia-sip/sofia-sip.mk b/package/sofia-sip/sofia-sip.mk
index 5c383400ff..274c72fce8 100644
--- a/package/sofia-sip/sofia-sip.mk
+++ b/package/sofia-sip/sofia-sip.mk
@@ -30,7 +30,7 @@ SOFIA_SIP_CONF_OPTS += \
 	--without-openssl
 endif
 
-ifeq ($(BR2_ENABLE_DEBUG),y)
+ifeq ($(BR2_ENABLE_DEBUG),)
 SOFIA_SIP_CONF_OPTS += --enable-ndebug
 endif
 



More information about the buildroot mailing list