[Buildroot] [PATCH v3 3/3] package/makedevs: coding style and whitespace cleanup

[Joachim Wiberg]

On 1/1/22 3:13 PM, Yann E. MORIN wrote:
> Joachim, All,
> On 2021-12-23 10:08 +0100, Joachim Wiberg spake thusly:
>> This program is cobbled up with parts from all over the place, mostly
>> BusyBox, so the style has not been kept consistent.  This patch is a
>> modest attempt to clean it up a bit.  Some changes, e.g., comments are
>> for consistency with the rest of the program.
>>
>>  - The (new) top level .clang-format file has been used as an aid
>>  - Overly long lines have been kept to keep the diff small and any
>>    discussions on max line length in the project to a minimum
>>  - Comment indentation has been kept, again to keep the diff small
> While I appreciate the rasoning, I think that, if we have a code style
> and a linter/reformatter, then we should just mechanically apply it and
> not manually apply parts of the rules.
> Otherwise, it does not help the maintenance/review anymore than the
> current state.
> So, I would be of the opinion that we should just blindly apply
> clang-format and be done with that.

Agreed.

> However, I'm also afraid that there might be different reformatting
> rules based on the clang-format version... Maybe the version we use
> should be documented somewhere?

Possibly, but in that case this would be a problem also in other
projects, e.g. the kernel.  I'd lean more towards syncing with kernel
.clang-format if that should turn out to be a regular problem.

Best regards
 /Joachim