[Buildroot] [PATCH v2 1/1] package/python-pyqt5: Fix parallel build

Arnout Vandecappelle arnout at mind.be
Tue Jan 4 18:09:31 UTC 2022



On 03/01/2022 17:54, Florent AUMAITRE wrote:
> This patch fix build of python-pyqt5 package when parallel build is used

  This explanation was a bit too terse. I tried to invent something that is more 
complete:

     pyqt5 uses qmake internally, but is python package rather than a qmake
     package. Therefore, we need to manually apply the same fixup as for
     qmake packages.

     Without this, top-level parallel build may fail because dependencies are
     looked for in the qt5 per-package staging directory instead of the
     python-pyqt5 one.

Hopefully that's more or less correct :-)

> 
> Signed-off-by: Florent AUMAITRE <florent.aumaitre at medianesysteme.com>
> 
> Changes v1 -> v2:
>    - Re-use the existing QT5_INSTALL_QT_CONF macro from package/qt5/qt5.mk  (suggested by Thomas Petazzoni)

  This should go below a --- line, i.e.:

---
Changes v1 -> v2:


  That way, it is not part of the git history.

  Applied to master with those things changed, thanks.

  Regards,
  Arnout

> 
> Signed-off-by: Florent AUMAITRE <florent.aumaitre at medianesysteme.com>
> ---
>   package/python-pyqt5/python-pyqt5.mk | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/package/python-pyqt5/python-pyqt5.mk b/package/python-pyqt5/python-pyqt5.mk
> index 8f28c90d15..b05043563e 100644
> --- a/package/python-pyqt5/python-pyqt5.mk
> +++ b/package/python-pyqt5/python-pyqt5.mk
> @@ -152,6 +152,11 @@ define PYTHON_PYQT5_GENERATE_QTDETAIL
>   	)
>   endef
>   
> +# The file "qt.conf" can be used to override the hard-coded paths that are
> +# compiled into the Qt library. We need it to make "qmake" relocatable and
> +# tweak the per-package install pathes
> +PYTHON_PYQT5_PRE_CONFIGURE_HOOKS += QT5_QT_CONF_FIXUP
> +
>   PYTHON_PYQT5_CONF_OPTS = \
>   	--bindir $(TARGET_DIR)/usr/bin \
>   	--destdir $(TARGET_DIR)/usr/lib/$(PYTHON_PYQT5_PYTHON_DIR)/site-packages \
> 



More information about the buildroot mailing list