[Buildroot] [PATCH v3] package/opensc: new package

[Thomas Petazzoni]

Hello José,

On Thu, 13 Jan 2022 13:49:51 +0200
José Pekkarinen <jose.pekkarinen at unikie.com> wrote:

> diff --git a/package/opensc/Config.in b/package/opensc/Config.in
> new file mode 100644
> index 0000000000..5ee52d1de6
> --- /dev/null
> +++ b/package/opensc/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_OPENSC
> +	bool "opensc"
> +	depends on !BR2_STATIC_LIBS # dlopen()
> +	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM

Unfortunately, this is not acceptable. If it breaks with this
particular toolchain, it's also likely to break with other toolchains
that share similar characteristics (gcc version, etc.).

> +	select BR2_PACKAGE_PCSC_LITE
> +	select BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL

Why do you force OpenSSL here? Is LibreSSL confirmed to not work with
opensc? If so, please add a comment above this select that explains
what explain is broken.

If you select BR2_PACKAGE_PCSC_LITE, you also need to inherit its
dependencies, i.e:

        depends on BR2_TOOLCHAIN_HAS_THREADS
        depends on BR2_USE_MMU # fork()
        depends on !BR2_STATIC_LIBS

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com