[Buildroot] [PATCH 1/1] package/network-manager: add optional nmcli support

[Thomas Petazzoni]

Hello,

+Yann on legacy handling (see below)

On Wed, 26 Jan 2022 10:04:57 +0100
Michael Fischer <mf at go-sys.de> wrote:

> When NetworkManager is built without the READLINE package the nmcli was not build.

Well, this was kind of expected, and isn't really a correct
explanation for this change.

A better explanation I believe is more something like this:

"""
The network-manager package builds the nmcli utility when the readline
package is enabled. However, this is not necessarily obvious to the
user. Therefore, this commit adds an explicit option to enable the
nmcli tool, which automatically selects readline.
"""

> 
> Signed-off-by: Michael Fischer <mf at go-sys.de>

> +config BR2_PACKAGE_NETWORK_MANAGER_CLI
> +        bool "nmcli support"
> +        select BR2_PACKAGE_READLINE
> +        help
> +          This option enables support for NetworkManager Command Line Interface

I think this line is too long, make sure to run "make check-package".

But a bigger problem is the legacy handling. Indeed, before your patch,
a configuration with BR2_PACKAGE_NETWORK_MANAGER=y and
BR2_PACKAGE_READLINE=y gets nmcli. After your patch, such a
configuration no longer has nmcli compiled, because
BR2_PACKAGE_NETWORK_MANAGER_CLI is not enabled.

Is this important to address, I don't know.

Is it possible to address is by doing:

config BR2_PACKAGE_NETWORK_MANAGER_CLI
        bool "nmcli support"
	default y if BR2_PACKAGE_READLINE
        select BR2_PACKAGE_READLINE

I don't know if Kconfig is happy about such a construct. Yann? :-)

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com