[Buildroot] [git commit] utils/check-package: improve shellcheck reproducibility

Arnout Vandecappelle (Essensium/Mind) arnout at mind.be
Mon Jul 25 21:52:47 UTC 2022


commit: https://git.buildroot.net/buildroot/commit/?id=eaa1a43ab7281f70754405441501712a4e2b9981
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

shellcheck is already in use to check SysV init scripts.
Currently its results can be affected by the existence of a
.shellcheckrc file in any parent directory.

For instance, in this example:
(1) /path/.shellcheckrc
(2) /path/to/.shellcheckrc
(3) /path/to/buildroot
the configs from file (1) are ignored and the configs from file (2)
override the default values from the shellcheck binary.
So the config file affects the check-package result for SysV scripts.

Avoid this reproducibility issue by adding an empty config file to the
buildroot topdir.

It can also eventually contain configs (different from default values
from sheelcheck) that we want as a standard to all shell scripts tested
by check-package.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
---
 .shellcheckrc | 0
 DEVELOPERS    | 1 +
 2 files changed, 1 insertion(+)

diff --git a/.shellcheckrc b/.shellcheckrc
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/DEVELOPERS b/DEVELOPERS
index 19f383aef6..504a6bb018 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2474,6 +2474,7 @@ F:	package/libhttpparser/
 
 N:	Ricardo Martincoski <ricardo.martincoski at datacom.com.br>
 F:	.flake8
+F:	.shellcheckrc
 F:	package/atop/
 F:	package/thermald/
 F:	support/testing/infra/



More information about the buildroot mailing list