[Buildroot] [PATCH 4/4] package/python-diffoscope: Add as new package

[Arnout Vandecappelle]

On 23/07/2022 22:28, Romain Naour wrote:
> Hi Conrad,
> 
> Le 26/02/2021 à 17:09, Conrad Ratschan a écrit :
[snip]
>> +HOST_PYTHON_DIFFOSCOPE_DL_SUBDIR = python-diffoscope
>> +HOST_PYTHON_DIFFOSCOPE_NEEDS_HOST_PYTHON = python3
>> +HOST_PYTHON_DIFFOSCOPE_DEPENDENCIES = host-python-libarchive-c host-python-magic
> 
> Still, the dependency seems short here.
> 
> To ease Buildroot packaging, you can get some hint from other Linux Distribution
> packaging (Debian [1], Fedora [2], Archlinux [3] or even Yocto [4]).
> 
> The list of optional dependency of diffoscope is huge and if we compare with the
> Yocto packaging some runtime dependencies are missing (binutils vim
> squashfs-tools python3-rpm)
> 
> So at least we can build diffoscope but a limited (light) version with
> Buildroot.

  It looks like the light version is not going to be very useful, so unless 
there's a very good reason to build it in buildroot, I think it's better to rely 
on the distro-installed package.

  Also, it's really a debug tool, not something that is ever going to be needed 
during the build. Maybe you want CI not to just fail if the build is not 
reproducible, but also

  Therefore, I marked this series as Rejected.

  Regards,
  Arnout

> For a full version, you have to use the one from your build machine.
> 
> For example, only the autobuilder script use diffoscope but the one installed on
> the build machine.
> 
> It would be great if we can have a test case for this package.
> 
> [1]
> https://salsa.debian.org/reproducible-builds/diffoscope/-/blob/master/debian/control
> 
> [2] https://src.fedoraproject.org/rpms/diffoscope/blob/rawhide/f/diffoscope.spec
> 
> [3]
> https://github.com/archlinux/svntogit-community/blob/packages/diffoscope/trunk/PKGBUILD
> 
> [4]
> https://github.com/openembedded/openembedded-core/blob/c2cf956881c3b691691f50b00b0d6930d8abea6f/meta/recipes-support/diffoscope/diffoscope_218.bb
> 
> Best regards,
> Romain
> 
> 
>> +
>> +$(eval $(host-python-package))
> 
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot