[Buildroot] [PATCH 1/1] package/mesa3d: set cpp_rtti option

[James Hilliard]

On Tue, Jul 26, 2022 at 2:47 AM Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>
> James, Al;,
>
> On 2022-07-26 00:34 -0600, James Hilliard spake thusly:
> > This needs to be set based on BR2_PACKAGE_LLVM_RTTI being set.
>
> BR2_PACKAGE_LLVM_RTTI is a sub-option of llvm, so it somehow means
> that llvm should be a dependency of mesa3d, which your patch does not
> add.

It's an optional dependency.

>
> But we already have a conditional dependency on llvm, so this nex rtti
> option should be a sub-condition of BR2_PACKAGE_MESA3D_LLVM?

Setting -Dcpp_rtti=false when llvm isn't used is harmless, it seemed clearer
to just have the single independent conditional for BR2_PACKAGE_LLVM_RTTI.

>
> Regards,
> Yann E. MORIN.
>
> > Fixes:
> >  - http://autobuild.buildroot.net/results/e2ebc9a73ed421aa6be44fe41bb5224cc12f699d
> >
> > Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> > ---
> >  package/mesa3d/mesa3d.mk | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> > index 96520e2efd..652b5168d2 100644
> > --- a/package/mesa3d/mesa3d.mk
> > +++ b/package/mesa3d/mesa3d.mk
> > @@ -94,6 +94,12 @@ else
> >  MESA3D_CONF_OPTS += -Dgallium-vc4-neon=disabled
> >  endif
> >
> > +ifeq ($(BR2_PACKAGE_LLVM_RTTI),y)
> > +MESA3D_CONF_OPTS += -Dcpp_rtti=true
> > +else
> > +MESA3D_CONF_OPTS += -Dcpp_rtti=false
> > +endif
> > +
> >  # Drivers
> >
> >  #Gallium Drivers
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'