[Buildroot] [PATCH 1/4] package/wpa_supplicant: fixing "Invalid configuration line"

[Thomas Petazzoni]

On Tue, 7 Jun 2022 14:16:19 +0200
Angelo Compagnucci <angelo at amarulasolutions.com> wrote:

> > Then why do we provide an example configuration file? :-)
> 
> Is the one we provide really an example configuration file?  An example
> configuration file usually looks quite different!

Sorry I don't follow you. We provide and install
package/wpa_supplicant/wpa_supplicant.conf, which is an example
configuration.

Or perhaps your question was ironic/cynical, and I didn't get the joke?

> Indeed. It looks useless doing some configuration file mangling only to
> have it overwritten. We don't do that for other parameters, like autoscan
> for example, which in turn we should do following this logic.
> I think that the provided configuration file should work with provided
> default options, or we should consider all the optional values too, they
> are many more for wpa_supplicant. What happens if I configure EAP, or AP
> mode or the hotspot? Should we have "example" configuration sections
> enabled by those options?

I understand your point, and I agree it's difficult and probably too
complicated to have all the logic to adjust the example configuration
file to all possible sub-options of wpa_supplicant. We have to draw the
line somewhere and it's not very clear cut where to draw this line.

I just though a working wpa_cli / wpa_supplicant combo would be useful
to have as an out-of-the box experience when
BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE is enabled. I guess this was the
intention of the currently provided wpa_supplicant.conf.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com