[Buildroot] [PATCH] package/gcnano-binaries: bump version to 4.3.7

Köry Maincent kory.maincent at bootlin.com
Wed Jun 8 13:46:09 UTC 2022


Hello Thomas

On Wed, 8 Jun 2022 15:35:11 +0200
Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:

> Hello,
> 
> Commit title has an issue, you're bumping to 6.4.7

Doh, you are right, I don't know how my brain did this.

> 
> On Wed,  8 Jun 2022 15:29:57 +0200
> kory.maincent at bootlin.com wrote:
> 
> > -GCNANO_BINARIES_LIBRARIES = \
> > -	libgbm_viv libEGL libGAL libgbm libGLESv1_CM \
> > -	libGLESv2 libGLSLC libOpenVG libVSC
> > -
> >  GCNANO_BINARIES_USERLAND_SUBDIR =
> > gcnano-userland-multi-$(GCNANO_BINARIES_USERLAND_VERSION) 
> > -GCNANO_BINARIES_PKG_CONFIGS = egl gbm glesv1_cm glesv2 vg
> > -
> >  define GCNANO_BINARIES_INSTALL
> > -	$(foreach lib,$(GCNANO_BINARIES_LIBRARIES), \
> > -		$(INSTALL) -D -m 0755
> > $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/usr/lib/$(lib).$(GCNANO_BINARIES_LIB_VERSION).multi.release.so
> > \
> > -
> > $(1)/usr/lib/$(lib).$(GCNANO_BINARIES_LIB_VERSION).multi.release.so ; \
> > -		cp -a
> > $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/usr/lib/$(lib).so* $(1)/usr/lib
> > -	)
> > +	cd $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/release/drivers/ ; \
> > +	find . -type f -exec $(INSTALL) -D -m 0755 {} $(1)/usr/lib/{} \; ;
> > \
> > +	find . -type l -exec cp -a {} $(1)/usr/lib \; ; \  
> 
> The ; \ at the end is not needed, it is the last line of the command.

Yes indeed.

> 
> > +	cp -a $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/release/include/*
> > $(1)/usr/include/
> > +	ln -s gbm/gbm.h $(1)/usr/include/gbm.h
> > +	cd $(@D)/$(GCNANO_BINARIES_USERLAND_SUBDIR)/pkgconfig/ ; \
> > +	for file in * ; do \
> > +		sed -e "s|#PREFIX#|/usr|" $$file > $$file.temp ; \
> > +		$(INSTALL) -D -m 0644 $$file.temp
> > $(1)/usr/lib/pkgconfig/$$file ; \
> > +		rm $$file.temp ; \  
> 
> I'd say you can leave the $$file.tmp around in the build directory, it
> will not cause any problem.

It does, in the case we call the reinstall task, these temp files will be added
to the for loop.

Köry



More information about the buildroot mailing list