[Buildroot] [PATCH 1/1] package/expat: update site link

Fabrice Fontaine fontaine.fabrice at gmail.com
Thu Mar 17 10:17:37 UTC 2022


Hello,

Le jeu. 17 mars 2022 à 10:51, bruno seifert <bruno.seifert at 3brain.com> a écrit :
>
> expat is currently in the process of changing the file hosting site from
> sourceforge to github. This adjusts the site URL to the new github
> location. Old versions are already not available on sourceforge anymore.
>
> Signed-off-by: bruno seifert <bruno.seifert at 3brain.com>
> ---
> Backport to: all versions
> I think the hashes don't need to be changed, but someone who actually
> knows stuff should confirm that.

Indeed, the hash is the same.

> Feel free to adjust the name and syntax. I've just started working a month a go and really don't know what I'm doing.
>
> Signed-off-by: bruno seifert <bruno.seifert at 3brain.com>
> ---
>  package/expat/expat.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/expat/expat.mk b/package/expat/expat.mk
> index b29b0e1d26..3dba920083 100644
> --- a/package/expat/expat.mk
> +++ b/package/expat/expat.mk
> @@ -5,7 +5,8 @@
>  ################################################################################
>
>  EXPAT_VERSION = 2.4.7
> -EXPAT_SITE = http://downloads.sourceforge.net/project/expat/expat/$(EXPAT_VERSION)
> +EXPAT_VERSION_TO_URL = $(subst .,_,$(EXPAT_VERSION))
> +EXPAT_SITE = https://github.com/libexpat/libexpat/releases/download/R_$(EXPAT_VERSION_TO_URL)

A single liner would be better:
EXPAT_SITE = https://github.com/libexpat/libexpat/releases/download/R_$(subst
.,_,$(EXPAT_VERSION))

However, I don't understand why we have to update the URL now?
Can't we wait for the next expat bump?

>  EXPAT_SOURCE = expat-$(EXPAT_VERSION).tar.xz
>  EXPAT_INSTALL_STAGING = YES
>  EXPAT_DEPENDENCIES = host-pkgconf
> --
> 2.25.1
>
>
> --
>
> 3Brain AG
> Einsiedlerstrasse 30
> 8820 Wädenswil
> Switzerland
> +41 81 322 70 86
>
> www.3brain.com <https://www.3brain.com/>
>
>  <https://twitter.com/3brain>
>  <https://www.linkedin.com/company/3brain/>
> <https://www.youtube.com/channel/UCLSFhw2saf7RdZt3Emmvt_Q>
> <https://goo.gl/maps/6dA7fb5je94L4Pyf6>
>
>
>
>
>
>
>
>
Best Regards,

Fabrice



More information about the buildroot mailing list