[Buildroot] [PATCH] package/pkg-golang: fix build with per-package directories

Peter Korsgaard peter at korsgaard.com
Mon Mar 7 21:10:01 UTC 2022


>>>>>   <yann.morin at orange.com> writes:

 > From: "Yann E. MORIN" <yann.morin at orange.com>
 > Build with per-package directory is broken, because go is not found in
 > the PATH, when trying to download and vendor a go package.

 > This is because FOO_DL_ENV contains $(HOST_GO_COMMON_ENV), which defines
 > the PATH as PATH=$(BR_PATH). This is correct, except this is expanded at
 > the time the golang-package macro is evaluated, which means PATH
 > contains the 'global' BR_PATH, i.e.: $(O)/host/bin:$(O)/host/sbin:...

 > However, with PPD, this does not yet exist at build time; only the
 > per-package hoqt directory exists.

s/hoqt/host/

 > We want to have it expanded at the time the recipe is run, so like all
 > other variables, we need to $$-expand it.

 > At the same time, also $$-expand two other variables (even though those
 > are benign, it is better for consistency that they be $$-expanded).

 > Signed-off-by: Yann E. MORIN <yann.morin at orange.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
 > Cc: Anisse Astier <anisse at astier.eu>
 > Cc: Christian Stewart <christian at paral.in>

Committed, thanks.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list