[Buildroot] [PATCH v8 5/5] package/qt5/qt5webengine: bump to version 5.15.8

[James Hilliard]

On Tue, May 17, 2022 at 1:35 AM Peter Korsgaard <peter at korsgaard.com> wrote:
>
> Hi,
>
> On 15/02/2022 02.53, James Hilliard wrote:
> > We need to use the separate package for the chromium submodule
> > which has python3 support patches.
> >
> > We also need to apply a patch to qt5webengine to allow building with
> > python3.
> >
> > Drop a patch which is now upstream.
> >
> > We need to set QT5WEBENGINE_SYNC_QT_HEADERS = YES as we are building
> > from a repository archive instead of a release archive.
> >
> > We need to add some new required dependencies to qt5webengine so that
> > it will build.
> >
> > Switch libraries to system libraries instead of bundled when possible.
> >
> > Migrate unsupported WEBENGINE_CONFIG to new config flag option.
> >
> > Override feature detection using config override flags to ensure we
> > get the expected features enabled/disabled as autodetection logic
> > may otherwise disable features without throwing build errors.
> >
> > Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
>
> I tried applying patch 1, 2, 3 and 5 (which took some effort as there
> seems to be some DOS newlines confusing patchwork) and did a test build
> for 32bit ARM:
>
> BR2_arm=y
> BR2_cortex_a7=y
> BR2_ARM_INSTRUCTIONS_THUMB2=y
> BR2_CCACHE=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
> BR2_PACKAGE_MESA3D=y
> BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
> BR2_PACKAGE_MESA3D_OPENGL_EGL=y
> BR2_PACKAGE_MESA3D_OPENGL_ES=y
> BR2_PACKAGE_QT5=y
> BR2_PACKAGE_QT5WEBENGINE=y
>
> But that fails building v8_snapshot/gen-regexp-special-case. Notice the
> -m32 that get passed:
>
> [19941/21833] LINK v8_snapshot/gen-regexp-special-case
> FAILED: v8_snapshot/gen-regexp-special-case
> /home/peko/source/buildroot/output-qt/build/qt5webengine-5.15.8/host-bin/python
> "../../3rdparty/chromium/build/toolchain/gcc_li
>
>                                  nk_wrapper.py"
> --output="v8_snapshot/gen-regexp-special-case" -- /usr/bin/g++ -pie
> -Wl,--fatal-warnings -Wl,--build-id=sha1 -fP
>
>                               IC -Wl,-z,noexecstack -Wl,-z,relro
> -Wl,-z,now -Wl,-z,defs -Wl,--as-needed -m32 -pie -Wl,--disable-new-dtags
> -Wl,-O2 -Wl,--gc-se
>
>      ctions -L/usr/lib -o "v8_snapshot/gen-regexp-special-case"
> -Wl,--start-group @"v8_snapshot/gen-regexp-special-case.rsp"  -Wl,--
>
>                                                       end-group  -ldl
> -lpthread -lrt -licui18n -licuuc -licudata
> /usr/bin/ld: skipping incompatible
> /usr/lib/x86_64-linux-gnu/libicui18n.so when searching for -licui18n
> /usr/bin/ld: skipping incompatible
> /usr/lib/x86_64-linux-gnu/libicui18n.a when searching for -licui18n
> /usr/bin/ld: cannot find -licui18n
> /usr/bin/ld: skipping incompatible
> /usr/lib/x86_64-linux-gnu/libicui18n.so when searching for -licui18n
> /usr/bin/ld: skipping incompatible /usr/lib/x86_64-linux-gnu/libicuuc.so
> when searching for -licuuc
> /usr/bin/ld: skipping incompatible /usr/lib/x86_64-linux-gnu/libicuuc.a
> when searching for -licuuc
> /usr/bin/ld: cannot find -licuuc
> /usr/bin/ld: skipping incompatible /usr/lib/x86_64-linux-gnu/libicuuc.so
> when searching for -licuuc
> /usr/bin/ld: skipping incompatible
> /usr/lib/x86_64-linux-gnu/libicudata.so when searching for -licudata
> /usr/bin/ld: skipping incompatible
> /usr/lib/x86_64-linux-gnu/libicudata.a when searching for -licudata
> /usr/bin/ld: cannot find -licudata
> /usr/bin/ld: skipping incompatible
> /usr/lib/x86_64-linux-gnu/libicudata.so when searching for -licudata
> collect2: error: ld returned 1 exit status
> [19945/21833] CXX v8_snapshot/obj/v8/v8_libsampler/sampler.o
> ninja: build stopped: subcommand failed.
> make[5]: *** [Makefile.gn_run:362: run_ninja] Error 1
> make[4]: *** [Makefile:82: sub-gn_run-pro-make_first] Error 2
> make[3]: *** [Makefile:79: sub-core-make_first] Error 2
> make[2]: *** [Makefile:49: sub-src-make_first] Error 2
> make[1]: *** [package/pkg-generic.mk:293:
> /home/peko/source/buildroot/output-qt/build/qt5webengine-5.15.8/.stamp_built]
> Error 2
>
>
> Any ideas? Notice that I did NOT apply patch 4 yet.

I think patch 4 was needed for fixing some linker issues with pkg-config
resolved dependencies like icu.

>
> > ---
> > Changes v7 -> v8:
> >    - add missing BR2_PACKAGE_QT5BASE_HARFBUZZ select
> >
> > Changes v5 -> v6:
> >    - switch to python3
> >    - fix up config flags and rebase
> >
> > Changes v3 -> v4:
> >    - linker fixes
> >
> > Changes v2 -> v3:
> >    - add kconfig entries
> > ---
> >   package/qt5/qt5.mk                            |    1 -
> >   .../0002-Add-python3-build-support.patch      |  168 +++
> >   ...m-breakpad-fix-build-with-glibc-2.34.patch |   76 --
> >   package/qt5/qt5webengine/Config.in            |   14 +
> >   .../qt5/qt5webengine/host-python-wrapper.in   |    3 +
> >   package/qt5/qt5webengine/qt5webengine.hash    | 1001 +----------------
> >   package/qt5/qt5webengine/qt5webengine.mk      |  160 ++-
> >   7 files changed, 323 insertions(+), 1100 deletions(-)
> >   create mode 100644 package/qt5/qt5webengine/0002-Add-python3-build-support.patch
> >   delete mode 100644 package/qt5/qt5webengine/0002-chromium-breakpad-fix-build-with-glibc-2.34.patch
> >   create mode 100644 package/qt5/qt5webengine/host-python-wrapper.in
> --
> Bye, Peter Korsgaard
>
>
>