[Buildroot] [PATCH v1 1/4] board/zynqmp/post-build.sh: auto-generate extlinux.conf

[Neal Frager]

Hi Luca,

>
>>     FILE="${BOARD_DIR}/extlinux.conf"
>>     if test -f "$FILE"; then
>>         install -m 0644 -D "${BOARD_DIR}/extlinux.conf" "${BINARIES_DIR}/extlinux.conf"
>
>> Right, but use "${FILE}" after -D.
>
> I just want to make sure I am not missing something.  I have changed the script to the following:
>
> if test -f "${FILE}"; then
>          install -m 0644 -D "${BOARD_DIR}/extlinux.conf" "${BINARIES_DIR}/extlinux.conf"
>
> Is there another -D I need to add somewhere?

> I didn't explain clearly, sorry. What I mean is quite trivial: you can simplify this:

>  install -m 0644 -D "${BOARD_DIR}/extlinux.conf" ...

> with this:

>  install -m 0644 -D "${FILE}" ...

Ah, I see.  Yes, that would have been another simplification.
In the v2 patch set, I added the fourth patch that removes the if statement completely.
So in the end, this line is going away anyway.

Please let me know what you think of v2.

Thanks for your review and support!

Best regards,
Neal Frager
AMD