[Buildroot] [PATCH 1/1] package/python-opcua-asyncio: bump to version 1.0.0

James Hilliard james.hilliard1 at gmail.com
Thu Nov 3 21:38:05 UTC 2022


On Thu, Nov 3, 2022 at 4:58 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello James,
>
> On Thu,  3 Nov 2022 07:28:29 -0600
> James Hilliard <james.hilliard1 at gmail.com> wrote:
>
> > Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> > ---
> >  package/python-opcua-asyncio/python-opcua-asyncio.hash | 6 ++++--
> >  package/python-opcua-asyncio/python-opcua-asyncio.mk   | 6 +++---
> >  2 files changed, 7 insertions(+), 5 deletions(-)
> >
> > diff --git a/package/python-opcua-asyncio/python-opcua-asyncio.hash b/package/python-opcua-asyncio/python-opcua-asyncio.hash
> > index d8aee272de..36b16a1596 100644
> > --- a/package/python-opcua-asyncio/python-opcua-asyncio.hash
> > +++ b/package/python-opcua-asyncio/python-opcua-asyncio.hash
> > @@ -1,3 +1,5 @@
> > -# Locally computed
> > -sha256  e5fab37a92162351fe40cab43df09db8a2e9f8b8a2a8f13ed680aa6f6d687ec3  opcua-asyncio-0.8.4.tar.gz
> > +# md5, sha256 from https://pypi.org/pypi/asyncua/json
> > +md5  a52df0dc0586abd1592c97a0274d1c9d  asyncua-1.0.0.tar.gz
> > +sha256  25966e374b0c90da112a96e9dbc5cc36c123b2b60412eac6f26b04a4b0b4d91e  asyncua-1.0.0.tar.gz
>
> Are you sure this is the same thing: opcua-asyncio-0.8.4.tar.gz and
> asyncua-1.0.0.tar.gz ?

Should be:
https://github.com/FreeOpcUa/opcua-asyncio#installation

>
> > +# Locally computed sha256 checksums
> >  sha256  da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768  COPYING
> > diff --git a/package/python-opcua-asyncio/python-opcua-asyncio.mk b/package/python-opcua-asyncio/python-opcua-asyncio.mk
> > index 50b581037b..54f8a1d0a0 100644
> > --- a/package/python-opcua-asyncio/python-opcua-asyncio.mk
> > +++ b/package/python-opcua-asyncio/python-opcua-asyncio.mk
> > @@ -4,9 +4,9 @@
> >  #
> >  ################################################################################
> >
> > -PYTHON_OPCUA_ASYNCIO_VERSION = 0.8.4
> > -PYTHON_OPCUA_ASYNCIO_SOURCE = opcua-asyncio-$(PYTHON_OPCUA_ASYNCIO_VERSION).tar.gz
> > -PYTHON_OPCUA_ASYNCIO_SITE = $(call github,FreeOpcUa,opcua-asyncio,$(PYTHON_OPCUA_ASYNCIO_VERSION))
> > +PYTHON_OPCUA_ASYNCIO_VERSION = 1.0.0
> > +PYTHON_OPCUA_ASYNCIO_SOURCE = asyncua-$(PYTHON_ASYNCUA_VERSION).tar.gz
>
> I don't see how this can work: this package defines
> PYTHON_OPCUA_ASYNCIO_VERSION, but you use PYTHON_ASYNCUA_VERSION. Did
> you test this? :-)

I did...but I bet I had not yet purged the scanpypi generated package which
defined that variable from my working tree before testing.

Fixed in v2:
https://patchwork.ozlabs.org/project/buildroot/patch/20221103213628.1321537-1-james.hilliard1@gmail.com/

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com



More information about the buildroot mailing list