[Buildroot] [PATCH v2 2/4] package/mpd: add/enhance (kconfig + code) comments
Andreas Ziegler
br015 at umbiko.net
Wed Oct 5 09:10:30 UTC 2022
Align kconfig comments with descriptions in the mpd manual.
Add a kconfig comment to highlight the impact of ogg/vorbis selection.
Add comments to makefile to explain remaining multiple dependency creation.
Signed-off-by: Andreas Ziegler <br015 at umbiko.net>
---
Changes v1 -> v2:
- make this a separate patch
package/mpd/Config.in | 9 ++++++---
package/mpd/mpd.mk | 2 ++
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index 8f0af7b2d3..2606008e90 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -33,7 +33,7 @@ config BR2_PACKAGE_MPD_SQLITE
select BR2_PACKAGE_SQLITE
help
Enable sqlite database support.
- If you don't use sqlite it will use an ASCII database.
+ This is mandatory for the sticker database.
config BR2_PACKAGE_MPD_ZZIP
bool "zzip"
@@ -81,8 +81,8 @@ comment "Decoder plugins"
config BR2_PACKAGE_MPD_DSD
bool "dsd"
help
- Enable Digital Speech Decoder (DSD) support to play audio
- files encoded in a digital speech format.
+ Direct Stream Digital (DSD) support to play audio
+ files encoded in single bit format.
config BR2_PACKAGE_MPD_FAAD2
bool "faad2"
@@ -210,6 +210,9 @@ config BR2_PACKAGE_MPD_TWOLAME
help
Enable TwoLAME mp2 encoding.
+comment "for ogg/vorbis encoding enable vorbis decoder"
+ depends on !BR2_PACKAGE_MPD_VORBIS
+
comment "Input plugins"
config BR2_PACKAGE_MPD_CDIO_PARANOIA
diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index 4d73e6de03..feab894f0f 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -230,6 +230,7 @@ else
MPD_CONF_OPTS += -Dopenal=disabled
endif
+# opus needs to be encapsulated in a container format, here ogg
ifeq ($(BR2_PACKAGE_MPD_OPUS),y)
MPD_DEPENDENCIES += opus libogg
MPD_CONF_OPTS += -Dopus=enabled
@@ -317,6 +318,7 @@ else ifeq ($(BR2_PACKAGE_MPD_UPNP_DISABLED),y)
MPD_CONF_OPTS += -Dupnp=disabled
endif
+# handle decoder and encoder simultaneously
ifeq ($(BR2_PACKAGE_MPD_VORBIS),y)
MPD_DEPENDENCIES += libvorbis
MPD_CONF_OPTS += -Dvorbis=enabled -Dvorbisenc=enabled
--
2.34.1
More information about the buildroot
mailing list