[Buildroot] [PATCH] arch/Config.in.powerpc: disable 64bits only target for PowerPC target variant
Romain Naour
romain.naour at gmail.com
Wed Sep 7 19:54:18 UTC 2022
Hello Yann, All,
Le 07/09/2022 à 09:30, Yann E. MORIN a écrit :
> Romain, All,
>
> On 2022-09-06 22:34 +0200, Romain Naour spake thusly:
>> It turn out that some PowerPC variant are actually 64bits only and
>> fail to build an internal toolchain (fail on glibc, uClibc-ng or musl
>> build).
> [--SNIP--]
>> diff --git a/arch/Config.in.powerpc b/arch/Config.in.powerpc
>> index c48edd3bb4..b321dd2d4c 100644
>> --- a/arch/Config.in.powerpc
>> +++ b/arch/Config.in.powerpc
>> @@ -66,10 +66,14 @@ config BR2_powerpc_604e
>> depends on !BR2_ARCH_IS_64
>> config BR2_powerpc_620
>> bool "620"
>> + # gcc support only powerpc64 target
>> + depends on BR2_ARCH_IS_64
>> # No C library supports this variant on ppc64le
>> depends on !BR2_powerpc64le
>
> As Thomas previously suggested, let's use positive logic:
>
> # gcc support only powerpc64 target, and
> # no C library supports this variant on ppc64le
> depends on BR2_powerpc64
>
> And so on for the others.
>
> Let's try and get simpler dependencies, which make it obvious under what
> conditions each CPU variant is actually available.
>
> Also, I think Joel's series [0] had even more changes in that area, and
> it would be so nice to see an updated revision.
Sorry I didn't remember of this patch series (more one month ago) and marked
changes requested. Actually I was not listening to the mailing list at that time
due to vacations :p
Joel, can you resend your series and include all the link I provided in my
commit log?
Best regards,
Romain
>
> [0] https://lore.kernel.org/buildroot/20220729000904.1295295-1-joel@jms.id.au/
>
> Regards,
> Yann E. MORIN.
>
More information about the buildroot
mailing list