[Buildroot] [PATCH] package/sox: work around gcc bug 68485

[Giulio Benetti]

Hi Yann,

On 11/09/22 21:17, Yann E. MORIN wrote:
> Giulio, All,
> 
> On 2022-09-10 00:15 +0200, Giulio Benetti spake thusly:
>> With Microblaze Gcc version <= 12.x the build fails due to gcc bug 68485:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. The bug show up when
>> building sox with optimization but not when building with -O0. To work
>> around this, if BR2_TOOLCHAIN_HAS_GCC_BUG_68458=y, we force using -O0.
> 
> Given your feedback on my review, I have amended the commit log into a
> form that looks (at least to me) more appropriate. Please review it and
> yell if I made a mistake.

It sounds very good.

Thank you!
-- 
Giulio Benetti
Benetti Engineering sas

> Applied to master, thanks.
> 
> Regards,
> Yann E. MORIN.
> 
>> Fixes:
>> http://autobuild.buildroot.net/results/ac4/ac4fbd55529ac7b4e635a11766f842cd25a833a1/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>> ---
>>   package/sox/sox.mk | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/package/sox/sox.mk b/package/sox/sox.mk
>> index 1896437ad4..d0329bf50d 100644
>> --- a/package/sox/sox.mk
>> +++ b/package/sox/sox.mk
>> @@ -26,6 +26,14 @@ SOX_CONF_OPTS = \
>>   	--with-distro="Buildroot" \
>>   	--disable-stack-protector
>>   
>> +SOX_CFLAGS = $(TARGET_CFLAGS)
>> +
>> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
>> +SOX_CFLAGS += -O0
>> +endif
>> +
>> +SOX_CONF_ENV += CFLAGS="$(SOX_CFLAGS)"
>> +
>>   ifeq ($(BR2_PACKAGE_ALSA_LIB_PCM),y)
>>   SOX_DEPENDENCIES += alsa-lib
>>   SOX_CONF_OPTS += --enable-alsa
>> -- 
>> 2.34.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>