[Buildroot] [PATCH v1 1/3 next] package/qt6/qt6serialport: use the CMAKE_NINJA flag

[Thomas Devoogdt]

Yann, All,


Ah wow, missed it, will change it too and re-run test-pkg with that one
include. The other three simply passed for the default test-pkg
architectures.


Kr,

Thomas

Op ma 7 aug. 2023 23:31 schreef Yann E. MORIN <yann.morin.1998 at free.fr>:

> Thomas, All,
>
> Thanks for this series. Thomas P. applied it before I had a chance to
> reply, so:
>
> Is there an issue with qt6svg, or did you just miss it?
>
> Regards,
> Yann E. MORIN.
>
> On 2023-08-07 16:58 +0200, Thomas Devoogdt spake thusly:
> > Use the newly introduce backend option
> (4cf79d9b71ff5cf2aede3f21e09ade7c7ac59606)
> > to specify what cmake backend to use, instead of special-coding it's use.
> >
> > Signed-off-by: Thomas Devoogdt <thomas.devoogdt at barco.com>
> > ---
> >  package/qt6/qt6serialport/qt6serialport.mk | 16 ++--------------
> >  1 file changed, 2 insertions(+), 14 deletions(-)
> >
> > diff --git a/package/qt6/qt6serialport/qt6serialport.mk
> b/package/qt6/qt6serialport/qt6serialport.mk
> > index 497719d4ec..bdb16dd892 100644
> > --- a/package/qt6/qt6serialport/qt6serialport.mk
> > +++ b/package/qt6/qt6serialport/qt6serialport.mk
> > @@ -10,6 +10,8 @@ QT6SERIALPORT_SOURCE =
> qtserialport-$(QT6_SOURCE_TARBALL_PREFIX)-$(QT6SERIALPORT
> >  QT6SERIALPORT_INSTALL_STAGING = YES
> >  QT6SERIALPORT_SUPPORTS_IN_SOURCE_BUILD = NO
> >
> > +QT6SERIALPORT_CMAKE_BACKEND = ninja
> > +
> >  QT6SERIALPORT_LICENSE = \
> >       GPL-2.0+ or LGPL-3.0, \
> >       GPL-3.0 with exception (tools), \
> > @@ -25,7 +27,6 @@ QT6SERIALPORT_LICENSE_FILES = \
> >       LICENSES/Qt-GPL-exception-1.0.txt
> >
> >  QT6SERIALPORT_CONF_OPTS = \
> > -     -GNinja \
> >       -DQT_HOST_PATH=$(HOST_DIR) \
> >       -DBUILD_WITH_PCH=OFF \
> >       -DQT_BUILD_EXAMPLES=OFF \
> > @@ -33,19 +34,6 @@ QT6SERIALPORT_CONF_OPTS = \
> >
> >  QT6SERIALPORT_DEPENDENCIES = \
> >       host-pkgconf \
> > -     host-ninja \
> >       qt6base
> >
> > -define QT6SERIALPORT_BUILD_CMDS
> > -     $(TARGET_MAKE_ENV) $(BR2_CMAKE) --build $(QT6SERIALPORT_BUILDDIR)
> > -endef
> > -
> > -define QT6SERIALPORT_INSTALL_STAGING_CMDS
> > -     $(TARGET_MAKE_ENV) DESTDIR=$(STAGING_DIR) $(BR2_CMAKE) --install
> $(QT6SERIALPORT_BUILDDIR)
> > -endef
> > -
> > -define QT6SERIALPORT_INSTALL_TARGET_CMDS
> > -     $(TARGET_MAKE_ENV) DESTDIR=$(TARGET_DIR) $(BR2_CMAKE) --install
> $(QT6SERIALPORT_BUILDDIR)
> > -endef
> > -
> >  $(eval $(cmake-package))
> > --
> > 2.41.0
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20230808/4aeb42db/attachment-0001.html>