[Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform

Tue Aug 15 01:10:39 UTC 2023

On Mon, Aug 14, 2023 at 04:39:46PM +0200, Thomas Petazzoni wrote:
> On Mon, 14 Aug 2023 10:48:34 +0800
> Yu Chien Peter Lin <peterlin at andestech.com> wrote:
> 
> > The BR2_PACKAGE_GLIBC_ARCH_SUPPORTS requires the RVA extension,
> > so we select it to enable and use glibc by default.
> 
> Thanks for the patch. However, the commit log is not a proper
> justification. Indeed, BR2_RISCV_ISA_CUSTOM_RVA should be enabled if
> the hardware supports it, not because glibc needs it. If glibc needs
> it, but the hardware doesn't support this instruction set extension, it
> doesn't make sense to enable it.

No problem, will reword properly in the next patch.
Thanks!

Peter Lin

> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com