[Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix typo in make target .stamp_built

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Aug 18 20:44:29 UTC 2023


On Fri, 18 Aug 2023 22:24:34 +0200
"Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:

> On 2023-08-18 22:03 +0200, Thomas Petazzoni via buildroot spake thusly:
> > On Fri, 18 Aug 2023 17:16:08 +0200
> > Bernd Kuhls <bernd at kuhls.net> wrote:
> >   
> > > This fix can be backported because the offending line was added in 2009.  
> 
> What is actualy broken?
> 
> As you noticed, the does has been there for moer than 14 years now, so
> if something obvious was broken, we'd have notriced by now.
> 
> So, if this is broken, it is not obvious, and we need to udnerstand how
> it is broken and why the fix is correct.

I don't think Bernd claimed anywhere that something is broken. He
claims there is a typo. I've also seen this double colon several times,
and it isn't consistent across the other similar make targets, and I
always wondered if it was needed or not. If it is not needed, we should
remove it to make this rule consistent with others. If it's needed, it
should be explained in a comment above it because it's not obvious
what's going on.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com



More information about the buildroot mailing list