[Buildroot] [PATCH 1/1] package/modem-manager: fix static build

[Aleksander Morgado]

Hey,

On Sun, Feb 19, 2023 at 11:45 PM Fabrice Fontaine
<fontaine.fabrice at gmail.com> wrote:
>
> Commit d769cfc13f6c2544f8bc5b6339d23763319a2383 was incomplete as
> plugins/meson.build still unconditionally calls shared_module. So
> disable plugins to fix the following static build failure raised since
> bump to version 1.20.2 in commit
> b95334b71fbdde0f7621b58ed35fa98df9e0966d:
>
> [238/417] Linking target plugins/libmm-shared-telit.so
> FAILED: plugins/libmm-shared-telit.so
>
> Plugins could be enabled back through builtin_plugins as soon as
> https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/1c4da332ee6e0d948f85a63f74cb27e89075c011
> lands in a stable release
>
> Fixes:
>  - http://autobuild.buildroot.org/results/deb2a752accb021392bb9dc3d06b2b1bf151535c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>  package/modem-manager/modem-manager.mk | 44 ++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
>
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index 979a80a8e9..824b9eda5a 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -80,6 +80,50 @@ else
>  MODEM_MANAGER_CONF_OPTS += -Dbash_completion=false
>  endif
>
> +ifeq ($(BR2_STATIC_LIBS),y)
> +MODEM_MANAGER_CONF_OPTS += \
> +       -Dplugin_generic=disabled \
> +       -Dplugin_altair_lte=disabled \
> +       -Dplugin_anydata=disabled \
> +       -Dplugin_broadmobi=disabled \
> +       -Dplugin_cinterion=disabled \
> +       -Dplugin_dell=disabled \
> +       -Dplugin_dlink=disabled \
> +       -Dplugin_fibocom=disabled \
> +       -Dplugin_foxconn=disabled \
> +       -Dplugin_gosuncn=disabled \
> +       -Dplugin_haier=disabled \
> +       -Dplugin_huawei=disabled \
> +       -Dplugin_intel=disabled \
> +       -Dplugin_iridium=disabled \
> +       -Dplugin_linktop=disabled \
> +       -Dplugin_longcheer=disabled \
> +       -Dplugin_mbm=disabled \
> +       -Dplugin_motorola=disabled \
> +       -Dplugin_mtk=disabled \
> +       -Dplugin_nokia=disabled \
> +       -Dplugin_nokia_icera=disabled \
> +       -Dplugin_novatel=disabled \
> +       -Dplugin_novatel_lte=disabled \
> +       -Dplugin_option=disabled \
> +       -Dplugin_option_hso=disabled \
> +       -Dplugin_pantech=disabled \
> +       -Dplugin_qcom_soc=disabled \
> +       -Dplugin_quectel=disabled \
> +       -Dplugin_samsung=disabled \
> +       -Dplugin_sierra_legacy=disabled \
> +       -Dplugin_sierra=disabled \
> +       -Dplugin_simtech=disabled \
> +       -Dplugin_telit=disabled \
> +       -Dplugin_thuraya=disabled \
> +       -Dplugin_tplink=disabled \
> +       -Dplugin_ublox=disabled \
> +       -Dplugin_via=disabled \
> +       -Dplugin_wavecom=disabled \
> +       -Dplugin_x22x=disabled \
> +       -Dplugin_zte=disabled
> +endif
> +

You can disable all plugins altogether with
"-Dauto_features=disabled"; it is the recommended way to do so in MM
1.20.
But I wonder, is it only to have the build with static libs pass? MM
1.20 without plugins will not be usable at all, at least one plugin is
required, so not sure how useful that is.

In MM 1.22 (or git main) there is the new "-Dbuiltin_plugins=true"
option that will embed all selected plugins within the ModemManager
daemon binary itself.

Cheers!