[Buildroot] [PATCH v4, 1/1] package/libmodsecurity: needs dynamic library

[Thomas Petazzoni]

Hello Fabrice,

On Mon, 20 Feb 2023 23:31:51 +0100
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> diff --git a/package/libmodsecurity/Config.in b/package/libmodsecurity/Config.in
> index b15d808759..2186d216f4 100644
> --- a/package/libmodsecurity/Config.in
> +++ b/package/libmodsecurity/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_LIBMODSECURITY
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	# libmodsecurity embeds several mbedtls source files

I've expanded a bit this comment, as it was not very clear why this
causes problem with static linking.

> -	depends on !(BR2_STATIC_LIBS && BR2_PACKAGE_LIBCURL_MBEDTLS)
> +	depends on !BR2_STATIC_LIBS
>  	select BR2_PACKAGE_PCRE2
>  	help
>  comment "nginx-modsecurity needs a toolchain w/ C++, threads"
>  	depends on BR2_PACKAGE_NGINX_HTTP
> -	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
> -
> -comment "nginx-modsecurity needs a toolchain w/ dynamic library"
> -	depends on BR2_PACKAGE_NGINX_HTTP
> -	depends on BR2_STATIC_LIBS && BR2_PACKAGE_LIBCURL_MBEDTLS
> +	depends on !BR2_INSTALL_LIBSTDCPP || \
> +		!BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS

Something was wrong here: you forgot to update the comment prompt
itself to mention the dependency on dynamic library.

I fixed both minor issues and applied to master. Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com