[Buildroot] [PATCH] package/git: prefer OpenSSL SHA-1 and SHA-256 implementation

Bagas Sanjaya bagasdotme at gmail.com
Fri Jan 20 02:35:16 UTC 2023


On 1/20/23 03:35, Peter Seiderer wrote:
> Or 'Makefile: make DC_SHA1 the default' ([1]):
> 
> 	Makefile: make DC_SHA1 the default
> 
> 	We used to use the SHA1 implementation from the OpenSSL library by
> 	default.  As we are trying to be careful against collision attacks
> 	after the recent "shattered" announcement, switch the default to
> 	encourage people to use DC_SHA1 implementation instead.  Those who
> 	want to use the implementation from OpenSSL can explicitly ask for
> 	it by OPENSSL_SHA1=YesPlease when running "make".
> 
> And 'INSTALL: remove discussion of SHA-1 backends' ([2]):
> 
> 	INSTALL: remove discussion of SHA-1 backends
> 
> 	The claim that OpenSSL is the default SHA-1 backend hasn't been true
> 	since e6b07da (Makefile: make DC_SHA1 the default, 2017-03-17),
> 	but more importantly tweaking the SHA-1 backend isn't something that's
> 	common enough to warrant discussing in the INSTALL document, so let's
> 	remove this paragraph.
> 
> 	This discussion was originally added in c538d2d (Add some
> 	installation notes in INSTALL, 2005-06-17) when tweaking the default
> 	backend was more common. The current wording was added in
> 	5beb577 (INSTALL: Describe dependency knobs from Makefile,
> 	2009-09-10).
> 

Ah, I didn't see the discussions above before I submitted this patch.

Withdrawn, thanks.

-- 
An old man doll... just what I always wanted! - Clara




More information about the buildroot mailing list