[Buildroot] [PATCH 1/1] package/dhcp: fix dhcp symlink in target/var/lib/dhcp

[Thomas Petazzoni]

Hello Charles,

+Yann in Cc. I will ask a few questions below, but honestly I'm not
super familiar with this part of the code base, so I might be asking
some stupid questions.

On Tue, 20 Jun 2023 10:07:26 -0700
Charles Hardin <ckhardin at gmail.com> wrote:

> In a readonly fs configuration the skeleton-init-fs will move

I supposed you meant skeleton-init-systemd. Indeed, there's nothing
named skeleton-init-fs in Buildroot as far as I know.

> the var directories to the usr/share/factory and the run a command
> like this:
> 
>    mv $(TARGET_DIR)/var $(TARGET_DIR)/usr/share/factory/var
>    mkdir -p $(TARGET_DIR)/var
>    for i in $(TARGET_DIR)/usr/share/factory/var/* \
>             $(TARGET_DIR)/usr/share/factory/var/lib/* \
>             $(TARGET_DIR)/usr/share/factory/var/lib/systemd/*; do
> 
> If the symlink is to the /tmp directory the glob compare on the
> dhcp link will evaluate and result in an incorrect entry being
> created in the resulting tmpfs mount on var.

I'm not able to parse your explanation here. Which glob compare? Which
evaluation?

> 
>     L+! /var/lib/dhcp - - - - ../usr/share/factory//var/lib/dhcp

Not obvious to me what is invalid in this entry, but admittedly I have
not done a test build/test run to investigate more.

Perhaps you can give a little bit more details to make the issue
obvious to the reviewer, and therefore help your patch to be merged?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com