[Buildroot] [git commit branch/2022.02.x] package/linux-tools/S10hyperv: fix shellcheck warnings
Peter Korsgaard
peter at korsgaard.com
Mon Mar 20 08:37:27 UTC 2023
commit: https://git.buildroot.net/buildroot/commit/?id=75e04c691e580165b7f203261a3ca2a2d1e3e25c
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/2022.02.x
When running "make check-package" on a system with shellcheck 0.9.0,
the command fails with output:
make check-package
package/linux-tools/S10hyperv:0: run 'shellcheck' and fix the warnings
...
2 warnings generated
This commit fixes the warnings reported by the command:
shellcheck package/linux-tools/S10hyperv
This commit also fixes the four-space indent by a single tab on the
changed lines. Since this fixes the indentation warnings of
check-package, the Indent exclusion in .checkpackageignore is also
removed.
Fixes:
In package/linux-tools/S10hyperv line 27:
return $ret
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
In package/linux-tools/S10hyperv line 48:
return $ret
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Signed-off-by: Julien Olivain <ju.o at free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
(cherry picked from commit c4173d8b08525f260fea8a2a1e805b806bcba9fc)
[Peter: drop .checkpackageignore, not in 2022.02.x]
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
package/linux-tools/S10hyperv | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/linux-tools/S10hyperv b/package/linux-tools/S10hyperv
index ec934bc972..32887d1b6c 100644
--- a/package/linux-tools/S10hyperv
+++ b/package/linux-tools/S10hyperv
@@ -24,7 +24,7 @@ start() {
for prog in ${PROGS}; do
start_one "${prog}" || ret=$?
done
- return $ret
+ return "$ret"
}
stop_one() {
@@ -45,7 +45,7 @@ stop() {
for prog in ${PROGS}; do
stop_one "${prog}" || ret=$?
done
- return $ret
+ return "$ret"
}
restart() {
More information about the buildroot
mailing list