[Buildroot] package/rtl8189fs: bug in conf, and a question

[Thomas Petazzoni]

Hello Indrek,

On Sat, 18 Mar 2023 23:46:15 +0200
Indrek Kruusa <indrek.kruusa at gmail.com> wrote:

> I'm trying to prepare a patch for MangoPi MQ (Allwinner D1s RISC-V). I'm
> almost there - Samuel Holland managed to mainline initial support for this
> board, so vanilla linux kernel 6.3-rc2 boots fine (with proper/modified
> u-boot version).
> The WiFi module is based on rtl8189ftv chip (SDIO connection) and its
> driver seems to be problematic.
> First, buildroot's package/rtl8189fs is currently broken; it points to the
> wrong commit (seems to be copy paste error, inherited from
> package/rtl8189es). The result is unusable. I updated it to the correct
> commit (on the correct branch) and the driver builds fine and loads fine.

Are you sure? It works fine here:

$ make rtl8189fs-extract
>>> rtl8189fs e58bd86c9d9408c648b1246a0dd76b16856ec172 Downloading
wget --passive-ftp -nd -t 3 -O '/home/thomas/projets/buildroot/output/build/.rtl8189fs-e58bd86c9d9408c648b1246a0dd76b16856ec172.tar.gz.bpmm05/output' 'https://github.com/jwrdegoede/rtl8189ES_linux/archive/e58bd86c9d9408c648b1246a0dd76b16856ec172/rtl8189fs-e58bd86c9d9408c648b1246a0dd76b16856ec172.tar.gz' 
--2023-03-18 23:20:29--  https://github.com/jwrdegoede/rtl8189ES_linux/archive/e58bd86c9d9408c648b1246a0dd76b16856ec172/rtl8189fs-e58bd86c9d9408c648b1246a0dd76b16856ec172.tar.gz
Resolving github.com (github.com)... 140.82.121.4
Connecting to github.com (github.com)|140.82.121.4|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/jwrdegoede/rtl8189ES_linux/tar.gz/e58bd86c9d9408c648b1246a0dd76b16856ec172 [following]
--2023-03-18 23:20:29--  https://codeload.github.com/jwrdegoede/rtl8189ES_linux/tar.gz/e58bd86c9d9408c648b1246a0dd76b16856ec172
Resolving codeload.github.com (codeload.github.com)... 140.82.121.9
Connecting to codeload.github.com (codeload.github.com)|140.82.121.9|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: ‘/home/thomas/projets/buildroot/output/build/.rtl8189fs-e58bd86c9d9408c648b1246a0dd76b16856ec172.tar.gz.bpmm05/output’

/home/thomas/projets/buildroo     [  <=>                                           ]   2,42M  9,05MB/s    in 0,3s    

2023-03-18 23:20:30 (9,05 MB/s) - ‘/home/thomas/projets/buildroot/output/build/.rtl8189fs-e58bd86c9d9408c648b1246a0dd76b16856ec172.tar.gz.bpmm05/output’ saved [2539299]

rtl8189fs-e58bd86c9d9408c648b1246a0dd76b16856ec172.tar.gz: OK (sha256: 96347dbfedd95a217fb89b7b295fe417b711dbad3db896ef0c2fa733c6d150fd)
>>> rtl8189fs e58bd86c9d9408c648b1246a0dd76b16856ec172 Extracting
gzip -d -c /home/thomas/dl/rtl8189fs/rtl8189fs-e58bd86c9d9408c648b1246a0dd76b16856ec172.tar.gz | tar --strip-components=1 -C /home/thomas/projets/buildroot/output/build/rtl8189fs-e58bd86c9d9408c648b1246a0dd76b16856ec172   -xf -

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com