[Buildroot] [PATCH] package/linux-tools: add USB tools (testusb and ffs-test)

[Herve Codina]

Hi Luca,

On Fri, 24 Mar 2023 10:33:07 +0100
Luca Ceresoli <luca.ceresoli at bootlin.com> wrote:

> Extend the linux-tools package to also build the userspace USB tools, which
> currently include testusb and ffs-test.
> 
> These tools are in the kernel tree since a long time, but a Makefile was
> added only in 5.9 to allow building in the same way as other tools provided
> with the kernel. Here we use the Makefile and thus version >= 5.9 is
> required. Support for older kernels may be added later if needed.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli at bootlin.com>
[...]
> +
> +ifeq ($(BR2_PACKAGE_LINUX_TOOLS_USBTOOLS_TESTUSB),)
> +define USBTOOLS_INSTALL_REMOVE_TESTUSB
> +	$(RM) -rf $(TARGET_DIR)/usr/bin/testusb

Why -r ?

> +endef
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LINUX_TOOLS_USBTOOLS_FFSTEST),)
> +define USBTOOLS_INSTALL_REMOVE_FFSTEST
> +	$(RM) -rf $(TARGET_DIR)/usr/bin/ffs-test

Same here

> +endef
> +endif
> +

Otherwise, looks good for me.

Thanks for this patch,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com