[Buildroot] [PATCH 1/1] package/dhcp: fix cross build

[Yann E. MORIN]

Bernd, All,

On 2023-10-02 21:51 +0200, Bernd Kuhls spake thusly:
> Fixes build error
> 
> Building dns library in /home/bernd/buildroot/br4/output/build/dhcp-4.4.3-
> P1/bind/bind-9.11.36/lib/dns
> ./gen: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found 
> (required by ./gen)
> make[4]: *** [Makefile:601: include/dns/enumtype.h] Error 1
> make[3]: *** [Makefile:595: include] Error 2
> 
> with this defconfig
> 
> BR2_x86_64=y
> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
> BR2_PACKAGE_DHCP=y
> 
> Please note that this build error only occurs when the target and the
> host system have the same arch. For example this defconfig builds fine:
> 
> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
> BR2_PACKAGE_DHCP=y
> 
> on a Debian 12 x86_64 host using glibc-2.36:
> 
> $ /lib/ld-linux.so.2  --version
> ld.so (Debian GLIBC 2.36-9+deb12u1) stable release version 2.36.
> 
> The error occurs since buildroot commit 34f8d874ee which bumped glibc
> from 2.37 to 2.38.
> 
> This patch is inspired by the Yocto Project:
> https://patchwork.yoctoproject.org/project/oe/patch/20230715212159.3265080-1-raj.khem@gmail.com/

That patch has an important tidbit of inoormation that yours is missing,
and that is important to get: this is passing the configure options to
the internal bind.

Indeed, I was very puzzled why passing the same --build, --host, and
--target as pkg-autotools already does, would fix the issue.

But indeed, isch dhcp internally configure a bundled bind, and messes
when doing so.

So your patch looks like it is correct.

However, I would challenge it on other grounds: ISC decided to stop
maintaing dhcp starting end of 2022, almost a year ago, when they
released the last version of dhcp.

Should we just drop that package now and be done with it?

Regards,
Yann E. MORIN.

> Signed-off-by: Bernd Kuhls <bernd at kuhls.net>
> ---
>  package/dhcp/dhcp.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
> index 7be40191c8..094d361e45 100644
> --- a/package/dhcp/dhcp.mk
> +++ b/package/dhcp/dhcp.mk
> @@ -32,6 +32,9 @@ DHCP_CONF_ENV = \
>  	CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
>  
>  DHCP_BIND_EXTRA_CONFIG = \
> +	--build=$(GNU_HOST_NAME) \
> +	--host=$(GNU_TARGET_NAME) \
> +	--target=$(GNU_TARGET_NAME) \
>  	BUILD_CC='$(HOSTCC)' \
>  	BUILD_CFLAGS='$(HOST_CFLAGS)' \
>  	BUILD_CPPFLAGS='$(HOST_CPPFLAGS)' \
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'