[Buildroot] [git commit branch/2023.05.x] package/mpd: introduce id3tag feature dependency
Peter Korsgaard
peter at korsgaard.com
Mon Sep 11 07:21:25 UTC 2023
commit: https://git.buildroot.net/buildroot/commit/?id=1ae271d78f137c718aee096a22dff87b3fce2c66
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/2023.05.x
id3tag is a sub-feature that is needed to extract information from mp3 files.
It selects the corresponding library and handles config settings. Two other
features need this sub-feature, but handle all library selections themselves
and omit enabling the id3tag feature. In consequence, users have to remember
to select both mp3 library and id3tag, otherwise the mpd executable will not
process mp3 files.
Reflect feature dependency in mpd Config.in to make id3tag selection automatic.
Signed-off-by: Andreas Ziegler <br015 at umbiko.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
(cherry picked from commit 876a365ea2a1c48477eabfe3ae600a9d48f1b4ab)
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
package/mpd/Config.in | 4 ++--
package/mpd/mpd.mk | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index 8f0af7b2d3..f350b7e72a 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -127,7 +127,7 @@ config BR2_PACKAGE_MPD_LIBSNDFILE
config BR2_PACKAGE_MPD_MAD
bool "mad"
default y
- select BR2_PACKAGE_LIBID3TAG
+ select BR2_PACKAGE_MPD_ID3TAG
select BR2_PACKAGE_LIBMAD
help
Enable mad input support.
@@ -141,7 +141,7 @@ config BR2_PACKAGE_MPD_MODPLUG
config BR2_PACKAGE_MPD_MPG123
bool "mpg123"
- select BR2_PACKAGE_LIBID3TAG
+ select BR2_PACKAGE_MPD_ID3TAG
select BR2_PACKAGE_MPG123
help
Enable mpg123 input support.
diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index b599e320e0..0205208946 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -190,7 +190,7 @@ MPD_CONF_OPTS += -Dsoxr=disabled
endif
ifeq ($(BR2_PACKAGE_MPD_MAD),y)
-MPD_DEPENDENCIES += libid3tag libmad
+MPD_DEPENDENCIES += libmad
MPD_CONF_OPTS += -Dmad=enabled
else
MPD_CONF_OPTS += -Dmad=disabled
@@ -204,7 +204,7 @@ MPD_CONF_OPTS += -Dmodplug=disabled
endif
ifeq ($(BR2_PACKAGE_MPD_MPG123),y)
-MPD_DEPENDENCIES += libid3tag mpg123
+MPD_DEPENDENCIES += mpg123
MPD_CONF_OPTS += -Dmpg123=enabled
else
MPD_CONF_OPTS += -Dmpg123=disabled
More information about the buildroot
mailing list