[Buildroot] [PATCH 3/6] package/go: make host package a virtual package

[Arnout Vandecappelle]

On 14/04/2024 08:28, Christian Stewart via buildroot wrote:
> Hi all,
> 
> On Fri, Apr 12, 2024 at 1:01 PM Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>> Thanks for this series, it really looks good! :-)
> 
> I agree that it looks good & having the go-bootstrap below the go/
> package is nice.
> 
> Haven't fully reviewed it yet but will try it.
> 
>> I anyway have a few comments and questions, please see below.
>>
> 
>> Not related to this patch, but still relevant to the discussion: it
>> would be even better if we could also have the possibility that the
>> stage-3 has the option of being a prebuilt go.
> 
> Using stage-3 as pre-built and host-go itself as compiled from source
> using the pre-built toolchain as the bootstrap one is ideal.
> 
> This is so that we can control which version of Go is used for the
> build for reproducibility.
> 
> Otherwise if the major version of Go installed on the host machine is
> different, it might produce different results, particularly when using
> cgo.

  The "system" go, i.e. the one installed on the build machine, is never used. 
This patch series gives the choice to either *download* the go binary, or build 
it from source.

  I don't think we want to have the option to use the system go in Buildroot. We 
do have that for things like cmake and gzip, but it's a bit painful to maintain. 
We also have it for python3, but only for a very small subset of packages (none 
of them Python packages). And since a prebuilt binary of go is anyway available 
for almost all platforms supported by Go, there is absolutely no reason not to 
just download it to be sure.

  Regards,
  Arnout

> 
> Best regards,
> Christian Stewart
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot