[Buildroot] [PATCH v2 1/2] package/xuantie-bins: new package

[Giulio Benetti]

Hi Yegor, Kilian,

On 05/12/23 00:12, yegorslists--- via buildroot wrote:
> From: Kilian Zinnecker <kilian.zinnecker at mail.de>
> 
> This patch adds a package for Xuantie binary blobs. These binaries
> are needed for the BeagleV-Ahead.
> 
> Signed-off-by: Kilian Zinnecker <kilian.zinnecker at mail.de>
> ---
>   DEVELOPERS                             |  5 +++--
>   package/Config.in                      |  1 +
>   package/xuantie-bins/Config.in         |  6 ++++++
>   package/xuantie-bins/xuantie-bins.hash |  1 +
>   package/xuantie-bins/xuantie-bins.mk   | 27 ++++++++++++++++++++++++++
>   5 files changed, 38 insertions(+), 2 deletions(-)
>   create mode 100644 package/xuantie-bins/Config.in
>   create mode 100644 package/xuantie-bins/xuantie-bins.hash
>   create mode 100644 package/xuantie-bins/xuantie-bins.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index f504ca8d36..4d18bc49d4 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1839,9 +1839,10 @@ N:	Kieran Bingham <kieran.bingham at ideasonboard.com>
>   F:	package/libcamera/
>   
>   N:	Kilian Zinnecker <kilian.zinnecker at mail.de>
> -F:	package/rockchip-rkbin/
> -F:	configs/rock5b_defconfig
>   F:	board/radxa/rock5b/
> +F:	configs/rock5b_defconfig

can you please provide a separate patch to alphabetize?

> +F:	package/rockchip-rkbin/
> +F:	package/xuantie-bins/
>   
>   N:	Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>
>   F:	package/wqy-zenhei/
> diff --git a/package/Config.in b/package/Config.in
> index fcc09b07c4..3772e2ac81 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -653,6 +653,7 @@ endmenu
>   	source "package/wipe/Config.in"
>   	source "package/xorriso/Config.in"
>   	source "package/xr819-xradio/Config.in"
> +	source "package/xuantie-bins/Config.in"
>   endmenu
>   
>   menu "Interpreter languages and scripting"
> diff --git a/package/xuantie-bins/Config.in b/package/xuantie-bins/Config.in
> new file mode 100644
> index 0000000000..a04497ce6b
> --- /dev/null
> +++ b/package/xuantie-bins/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_XUANTIE_BINS
> +	bool "xuantie-bins"
> +	depends on BR2_riscv
> +	help
> +	  This package provides binary blobs, needed for the
> +	  BeagleV-Ahead's SoC (TH1520).

Can you please describe a bit what those binaries are meant for?

> diff --git a/package/xuantie-bins/xuantie-bins.hash b/package/xuantie-bins/xuantie-bins.hash
> new file mode 100644
> index 0000000000..4d1ec297c9
> --- /dev/null
> +++ b/package/xuantie-bins/xuantie-bins.hash
> @@ -0,0 +1 @@
> +sha256  608e9fec79823996004f65ba692a76d741307b0de23552d147ad1b567e7054dc  xuantie-bins-0a2e02bb53758cc12448d8670e65c854528a96b4-br1.tar.gz
> diff --git a/package/xuantie-bins/xuantie-bins.mk b/package/xuantie-bins/xuantie-bins.mk
> new file mode 100644
> index 0000000000..3a5611cf36
> --- /dev/null
> +++ b/package/xuantie-bins/xuantie-bins.mk
> @@ -0,0 +1,27 @@
> +################################################################################
> +#
> +# xuantie-bins
> +#
> +################################################################################
> +
> +XUANTIE_BINS_VERSION = 0a2e02bb53758cc12448d8670e65c854528a96b4
> +XUANTIE_BINS_SITE = https://github.com/beagleboard/xuantie-ubuntu.git
> +XUANTIE_BINS_SITE_METHOD = git
> +XUANTIE_BINS_LICENSE = PROPRIETARY
> +
> +XUANTIE_BINS_INSTALL_IMAGES = YES
> +XUANTIE_BINS_INSTALL_TARGET = NO
> +
> +XUANTIE_BINS_FPGA_BIN_FILENAME = "bins/light_aon_fpga.bin"
> +XUANTIE_BINS_AUDIO_BIN_FILENAME = "bins/light_c906_audio.bin"
> +
> +define XUANTIE_BINS_INSTALL_IMAGES_CMDS
> +	$(foreach f, \
> +		$(XUANTIE_BINS_FPGA_BIN_FILENAME) \
> +		$(XUANTIE_BINS_AUDIO_BIN_FILENAME) \
> +		, \
> +		$(INSTALL) -D -m 0644 -t $(BINARIES_DIR) $(@D)/$(f)
> +	)
> +endef

Being only 2 files to be installed I'd prefer to see 2 lines instead of
foreach loop. Can you please change it accordingly?

Thank you
Best regards
-- 
Giulio Benetti
CEO&CTO at Benetti Engineering sas