[Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package

Yann E. MORIN yann.morin.1998 at free.fr
Mon Feb 5 13:47:40 UTC 2024


Marcus, All,

On 2024-02-05 14:38 +0100, Marcus Hoffmann via buildroot spake thusly:
> Forgot my SoB
> On 21.09.23 22:39, ~bubu wrote:
> > From: Marcus Hoffmann <marcus.hoffmann at othermo.de>
> > Calling `setup.py` build builds and installs  an empty package
> > after upstream changed their packaging. Calling setuptools via
> > `python -m build` builds the package correctly.
> Signed-off-by: Marcus Hoffmann <bubu at bubu1.eu>

Thanks. However, the SoB line needs to match the author of the commit,
and that does not match:
    Author:     Marcus Hoffmann <marcus.hoffmann at othermo.de>
    Signed-off-by: Marcus Hoffmann <bubu at bubu1.eu>

Regards,
Yann E. MORIN.

> > ---
> >   package/python-minimalmodbus/python-minimalmodbus.mk | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/package/python-minimalmodbus/python-minimalmodbus.mk b/package/python-minimalmodbus/python-minimalmodbus.mk
> > index 5a6e7733be..cb8a0d8cc9 100644
> > --- a/package/python-minimalmodbus/python-minimalmodbus.mk
> > +++ b/package/python-minimalmodbus/python-minimalmodbus.mk
> > @@ -7,7 +7,8 @@
> >   PYTHON_MINIMALMODBUS_VERSION = 2.1.1
> >   PYTHON_MINIMALMODBUS_SOURCE = minimalmodbus-$(PYTHON_MINIMALMODBUS_VERSION).tar.gz
> >   PYTHON_MINIMALMODBUS_SITE = https://files.pythonhosted.org/packages/37/fc/8a58f7bcdece751f16a4a9aac780acd1288aa8ac6adbffdd764c88fb71c6
> > -PYTHON_MINIMALMODBUS_SETUP_TYPE = setuptools
> > +PYTHON_MINIMALMODBUS_DEPENDENCIES = host-python-setuptools
> > +PYTHON_MINIMALMODBUS_SETUP_TYPE = pep517
> >   PYTHON_MINIMALMODBUS_LICENSE = Apache-2.0
> >   PYTHON_MINIMALMODBUS_LICENSE_FILES = LICENSE
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list