[Buildroot] [PATCH v2 1/2] package/xuantie-bins: new package
kilian.zinnecker at mail.de
kilian.zinnecker at mail.de
Sun Feb 11 12:15:35 UTC 2024
Hello Giulio, all,
[--SNIP--]
> can you please provide a separate patch to alphabetize?
I did so: https://gitlab.com/buildroot.org/buildroot/-/commit/
53fad3242d74b9fad11978429d6cc2879f783f4b
However, unfortunately Thomas de-alphabetized it again when he applied my
RZBoard V2L patches: https://gitlab.com/buildroot.org/buildroot/-/commit/
f003675119c9ca503afa19c04074e81c49538baf
I just send a v3 of the BeagleV-Ahead patches. After we get this series
applied, I will then again send a single patch to alphabetize.
[--SNIP--]
> > --- /dev/null
> > +++ b/package/xuantie-bins/Config.in
> > @@ -0,0 +1,6 @@
> > +config BR2_PACKAGE_XUANTIE_BINS
> > + bool "xuantie-bins"
> > + depends on BR2_riscv
> > + help
> > + This package provides binary blobs, needed for the
> > + BeagleV-Ahead's SoC (TH1520).
>
> Can you please describe a bit what those binaries are meant for?
I gave a brief description, but I don't know much about these. Maybe Robert
can give even more information, if more is needed?
[--SNIP--]
> > +XUANTIE_BINS_FPGA_BIN_FILENAME = "bins/light_aon_fpga.bin"
> > +XUANTIE_BINS_AUDIO_BIN_FILENAME = "bins/light_c906_audio.bin"
> > +
> > +define XUANTIE_BINS_INSTALL_IMAGES_CMDS
> > + $(foreach f, \
> > + $(XUANTIE_BINS_FPGA_BIN_FILENAME) \
> > + $(XUANTIE_BINS_AUDIO_BIN_FILENAME) \
> > + , \
> > + $(INSTALL) -D -m 0644 -t $(BINARIES_DIR) $(@D)/$(f)
> > + )
> > +endef
>
> Being only 2 files to be installed I'd prefer to see 2 lines instead of
> foreach loop. Can you please change it accordingly?
I unrolled the loop in my v3 of the patches.
Thanks for reviewing and best regards,
Kilian
More information about the buildroot
mailing list